589561 - (ietestcenter) HTML5 Media Elements 1/23: 'buffered' returns a TimeRanges object.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Darxus]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b4pre) Gecko/20100817 Minefield/4.0b4pre
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b4pre) Gecko/20100817 Minefield/4.0b4pre

Fails test.

Reproducible: Always

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

We need to s/HTMLTimeRanges/TimeRanges/q

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Thanks for filing all these ietestcenter bugs Darxus, much appreciated.

(In reply to comment #1)
> We need to s/HTMLTimeRanges/TimeRanges/q

 Ms2ger is correct, we've named our time ranges object HTMLTimeRanges, but the spec calls the interface TimeRanges:
http://www.whatwg.org/specs/web-apps/current-work/multipage/video.html#timeranges

We should fix this before we ship buffered in Firefox 4, it's a pretty easy fix.

Comment 3

[Darxus]

Chris: You're welcome, and thanks for the response.  I've been waiting to see how they were received to continue.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Looks like we also call MediaError HTMLMediaError. That should change too.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Rename HTMLTimeRanges to TimeRanges, HTMLMediaError to MediaError.

Rename HTMLTimeRanges to TimeRanges, HTMLMediaError to MediaError. We pass the ietestcenter test with this patch.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

nsIMediaError and nsITimeRanges should be nsIDOMMediaError and nsIDOMTimeRanges respectively. Other than that, this is good.

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch v2

With nsIDOM{MediaError,TimeRanges} instead of nsI{MediaError,TimeRanges}.

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

http://hg.mozilla.org/mozilla-central/rev/37f61e9d618a