589587 - Venkman should register to be in the "Developers" submenu in the new Firefox button

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[:Gijs (he/him)]

As in summary.

Comment 1

[Samit Badle]

Attachment: New overlay file with patch applied. See section with comment Firefox 4

Hi,

The developer menu in Firefox 4 will now get a Javascript debugger menu item. Apologies for not creating the patch and just attaching the replacement venkman-overlay.xul file.

Keep up the great work.

Kind regards,
Samit

Comment 2

[Colby Russell :crussell (no longer Mozilla-ing)]

Samit, you should attach the patch and request review from Gijs.

Comment 3

[Samit Badle]

Attachment: Patch for venkman-overlay.xul

Submitted changes as a patch file.

Comment 4

[:Gijs (he/him)]

Comment on attachment 469549 [details] [diff] [review]
Patch for venkman-overlay.xul

Look good, thanks!

Comment 5

[:Gijs (he/him)]

http://hg.mozilla.org/venkman/rev/a43de89ec090

Comment 6

[Philip Chee]

> http://hg.mozilla.org/venkman/rev/a43de89ec090
This is a null changeset. Can some one push the real patch instead?

Comment 7

[:Gijs (he/him)]

(In reply to comment #6)
> > http://hg.mozilla.org/venkman/rev/a43de89ec090
> This is a null changeset. Can some one push the real patch instead?

D'oh, so qimportbz doesn't care if your patch doesn't apply, or something. Lame! Anyway, http://hg.mozilla.org/venkman/rev/0bd89e7c12f5 does have the patch...

Thanks again Samit, and sorry for the delays!

Comment 8

[:Gijs (he/him)]

http://hg.mozilla.org/venkman/rev/662801d486aa