589615 - Put all preshints (at least for HTML, independent of document type) in the author level

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Darxus]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b4pre) Gecko/20100817 Minefield/4.0b4pre
Build Identifier: 

Fails test.

Reproducible: Always

Comment 1

[Boris Zbarsky [:bzbarsky]]

This test is either assuming that CSS2.1 section 6.4.4 includes XHTML when it says "HTML" (I see no basis for this assumption) or that default link styling is in the UA level in the cascade.  In Gecko it's in the user level.

So, unless the assumption about CSS2.1 is correct for some reason I missed, the test is broken and we need to get the IE folks to fix it.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Ok, the HTML5 spec does have verbiage about this.  http://www.whatwg.org/specs/web-apps/current-work/complete/rendering.html#the-css-user-agent-style-sheet-and-presentational-hints second paragraph of the introduction, in particular.

Furthermore, SVG says that its preshints should go in the author level too (SVG 1.1, section 6.4, paragraph starting "For user agents that support CSS, the presentation attributes must be translated".  We don't do that currently.

David, how would you feel about just putting all preshints in the author level?

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Yes, I think we should change this.

The CSS spec was never really explicit here; the XHTML WG clearly wanted the XML-like option, but we should make it HTML-like.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

http://test.csswg.org/suites/css2.1/20101001/xhtml1/html-precedence-003.xht

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Get rid of the non-HTML preshint level.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Rename the HTML preshint level to just the preshint level, since it's the only preshint level now.

Comment 7

[Boris Zbarsky [:bzbarsky]]

dbaron, do you think we should try to get this in for 2.0?

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 484226 [details] [diff] [review]
part 1.  Get rid of the non-HTML preshint level.

Seems like this comment should stay:
>-  //Enable/Disable entire author style level (Doc & PresHint levels)

r=dbaron

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 484227 [details] [diff] [review]
part 2.  Rename the HTML preshint level to just the preshint level, since it's the only preshint level now.

r=dbaron

Comment 10

[Boris Zbarsky [:bzbarsky]]

> Seems like this comment should stay:

Agreed and reinstated.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: roll-up for approval

This is fairly safe and fixes some reasonably prominent test failures.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Pushed:
  http://hg.mozilla.org/mozilla-central/rev/1133df9783f4
  http://hg.mozilla.org/mozilla-central/rev/65dfc25b1cae