589618 - [SeaMonkey 2.1, mochitest-browser-chrome] browser_522545.js | sessionstore got correct userTypedValue - Got example.org, expected mozilla.org

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Robert Kaiser]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1282499502.1282502435.6363.gz

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/common/tests/browser/browser_522545.js | sessionstore got correct userTypedValue - Got example.org, expected mozilla.org

Something's wrong in our own court in this test. :(

Comment 1

[Philip Chee]

I'm pretty sure I saw this before my userTypedValue patch landed.

Comment 2

[Misak Khachatryan]

The bug was opened before Your patch landed ;)

Comment 3

[Misak Khachatryan]

Attachment: clear existing tabs cache befor using them

I don't know why Firefox didn't hit this, but problem is that _collectTabData returns cached data of tab yet to be loaded. Suppose sessionstore opened a tab and cached it's data until load event indicates it's loaded. So if you call getbrowserstate ss actually returns a cached state of a tab. But if you do setbrowserstate before tab loaded and do getbrowserstate before new one loaded, ss will return cache of previous state. Maybe it's somehow related with SM specific "load" and "pageshow" event processing, or empty browser state which this test trying to set triggering this. Anyhow, this patch explicitly clears the cache of tab being reused.

Comment 4

[[e-mail]]

Attachment: Actually allow the load event to fire

I don't think we're allowing the load event to fire. This should fix that.

Comment 5

[Misak Khachatryan]

Comment on attachment 470309 [details] [diff] [review]
Actually allow the load event to fire

Oh, how simple ...
This rises another question - why firefox pass this test ?

Comment 6

[[e-mail]]

Pushed changeset dca910b78975 to comm-central.

Comment 7

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=14465696&tree=Mozilla-Aurora
Rev3 WINNT 5.1 mozilla-aurora debug test mochitest-other on 2012-08-17 03:23:59
slave: talos-r3-xp-008

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected example.org
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_522545.js | sessionstore got correct userTypedClear - Got undefined, expected 0