http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1282499502.1282502435.6363.gz TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/common/tests/browser/browser_522545.js | sessionstore got correct userTypedValue - Got example.org, expected mozilla.org Something's wrong in our own court in this test. :(
I'm pretty sure I saw this before my userTypedValue patch landed.
The bug was opened before Your patch landed ;)
Created attachment 470280 [details] [diff] [review] clear existing tabs cache befor using them I don't know why Firefox didn't hit this, but problem is that _collectTabData returns cached data of tab yet to be loaded. Suppose sessionstore opened a tab and cached it's data until load event indicates it's loaded. So if you call getbrowserstate ss actually returns a cached state of a tab. But if you do setbrowserstate before tab loaded and do getbrowserstate before new one loaded, ss will return cache of previous state. Maybe it's somehow related with SM specific "load" and "pageshow" event processing, or empty browser state which this test trying to set triggering this. Anyhow, this patch explicitly clears the cache of tab being reused.
Created attachment 470309 [details] [diff] [review] Actually allow the load event to fire I don't think we're allowing the load event to fire. This should fix that.
Comment on attachment 470309 [details] [diff] [review] Actually allow the load event to fire Oh, how simple ... This rises another question - why firefox pass this test ?
Pushed changeset dca910b78975 to comm-central.