Closed
Bug 589672
Opened 14 years ago
Closed 14 years ago
(ietestcenter) CSS3 Namespaces 15/17
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla2.0b5
People
(Reporter: darxus-mozillabug, Assigned: bzbarsky)
References
()
Details
Attachments
(1 file)
|
2.19 KB,
patch
|
dbaron
:
review+
dbaron
:
approval2.0+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b4pre) Gecko/20100817 Minefield/4.0b4pre
Build Identifier:
Test failed.
Reproducible: Always
Blocks: ietestcenter
Version: unspecified → Trunk
|
Assignee | |
Comment 1•14 years ago
|
||
This is a real issue. Fix is simple; patch coming up.
Assignee: nobody → bzbarsky
Status: UNCONFIRMED → NEW
Component: General → Style System (CSS)
Ever confirmed: true
Priority: -- → P1
QA Contact: general → style-system
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #468219 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs review]
Comment on attachment 468219 [details] [diff] [review]
Fix
r+a2.0=dbaron
Attachment #468219 -
Flags: review?(dbaron)
Attachment #468219 -
Flags: review+
Attachment #468219 -
Flags: approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs review] → [needs landing]
Er, as bz pointed out, the UngetToken should be in an else after the string-function if-else chain.
|
|
Assignee | |
Comment 5•14 years ago
|
||
Pushed:
http://hg.mozilla.org/mozilla-central/rev/6938c2023886
http://hg.mozilla.org/mozilla-central/rev/69be3500196b
(the latter to fix the orange, per comment 4).
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b5
You need to log in
before you can comment on or make changes to this bug.
Description
•