589727 - Typed Float32 Arrays broken on mozilla-central trunk

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Humphrey (:humph)]

The bug in bug 586387 was re-introduced with this recent merge:

http://hg.mozilla.org/mozilla-central/rev/7fb1bd5802f0.

Comment 1

[Robert Sayre]

no test in bug 586387. boo.

Comment 2

[David Humphrey (:humph)]

https://bugzilla.mozilla.org/show_bug.cgi?id=586387#c3 has one

Comment 3

[David Humphrey (:humph)]

Attachment: Vlad's bug comment test as trace-test

I haven't written trace-tests before, but following what I see in the tree, maybe this is what you want.  It certainly fails here.

Comment 4

[Robert Sayre]

OK, so what happened here is this:

vlad checked in changes to nanojit that were clobbered by a nanojit import. All nanojit changes must go to nanojit-central to avoid this fate.

we didn't land a test for this in TM, which would have caught this problem quite quickly.

Comment 5

[David Humphrey (:humph)]

Thanks for looking at this, Robert.  Do you have an ETA for re-landing these bits on m-c?  My audio landing is blocked on it being there, and I'm hoping to get it in prior to feature freeze.

If there's more or different tests you need, let me know and I'll try to help.

Comment 6

[Nicholas Nethercote [inactive]]

The test was landed here:

http://hg.mozilla.org/tracemonkey/rev/7f8a3c0942fb

The previously-clobbered nanojit change was relanded, see bug 586387 for details.

Comment 7

[David Humphrey (:humph)]

That's great, thanks for landing there.  How about mozilla-central?

Comment 8

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/7f8a3c0942fb