589755 - [D3D9] Canvas layer uses incorrect source with d2d surfaces

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Fixed!

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Image layers also have the same issue

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 468520 [details] [diff] [review]
Image layers also have the same issue

Bit of a weird name for the patch. But certainly a correct change.

Comment 4

[[e-mail]]

Comment on attachment 468520 [details] [diff] [review]
Image layers also have the same issue

No need for approval; blocks a blocker.

Comment 5

[Bas Schouten (:bas.schouten)]

(In reply to comment #4)
> Comment on attachment 468520 [details] [diff] [review]
> Image layers also have the same issue
> 
> No need for approval; blocks a blocker.

Did this change? I remember only a couple of weeks ago I was explicitly told this is not enough.

Comment 6

[[e-mail]]

Comment on attachment 468520 [details] [diff] [review]
Image layers also have the same issue

http://hg.mozilla.org/mozilla-central/rev/a05b88dde70e

Comment 7

[[e-mail]]

(In reply to comment #5)
> Did this change? I remember only a couple of weeks ago I was explicitly told
> this is not enough.

I was told it was, and it's been convention in the past. Sounds like your source and my source need to have a cagefight!

Comment 8

[Joe Drew (not getting mail)]

Cagefighting all the way down!

(IMO it doesn't matter if it's explicitly marked as blocking. We're all friends, bureaucracy just gets in the way.)