Vector interp shift performance 7% slower than array

RESOLVED FIXED

Status

Tamarin
Virtual Machine
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Chris Peyer, Assigned: Steven Johnson)

Tracking

(Blocks: 1 bug)

unspecified
Dependency tree / graph
Bug Flags:
flashplayer-qrb +

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Performance is consistently 7% slower than array with -Dinterp.  Performance is equivalent when run with jit.

Test is located in
asteam/hg/qe/projects/performance/tests/language/vector/shift.abc
Flags: flashplayer-qrb?
(Reporter)

Updated

8 years ago
See Also: → bug 589824

Updated

8 years ago
Assignee: nobody → stejohns
Flags: flashplayer-qrb? → flashplayer-qrb+
(Assignee)

Updated

8 years ago
Depends on: 605324
(Assignee)

Comment 1

8 years ago
Created attachment 484186 [details] [diff] [review]
Patch

Make shift a native method; with this patch, the testcase is about 5% faster that Array.shift in interp mode.
Attachment #484186 - Flags: review?(wsharp)

Comment 2

8 years ago
Comment on attachment 484186 [details] [diff] [review]
Patch

Looks fine besides the fact that is based upon the avmplus list implementation of vector so doesn't quite match what's in TR currently.
Attachment #484186 - Flags: review?(wsharp) → review+
(Assignee)

Comment 3

8 years ago
Yeah, it can't land till that one does, just an end-of-day quickie patch.
(Assignee)

Comment 4

8 years ago
TR 5421:e7f070d39ffd
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.