589871 - Fix GetValidationmessage warnings in content/html/content/src/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

There are some warnings because there is nsIConstraintValidation::GetValidationMessage and nsHTML<Foo>Element::GetValidationMessage. The later hide the former. That's what we want but 'use' should be used to get ride of compiler warnings.

I will do that after beta5 if no one jump on it in the mean time.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 468393 [details] [diff] [review]
Patch v1

>From: Ms2ger <[e-mail]>
>
>diff --git a/content/html/content/src/nsHTMLButtonElement.cpp b/content/html/content/src/nsHTMLButtonElement.cpp
>--- a/content/html/content/src/nsHTMLButtonElement.cpp
>+++ b/content/html/content/src/nsHTMLButtonElement.cpp
>@@ -77,16 +77,18 @@ static const nsAttrValue::EnumTable kBut
> // Default type is 'submit'.
> static const nsAttrValue::EnumTable* kButtonDefaultType = &kButtonTypeTable[2];
> 
> class nsHTMLButtonElement : public nsGenericHTMLFormElement,
>                             public nsIDOMHTMLButtonElement,
>                             public nsIConstraintValidation
> {
> public:
>+  using nsIConstraintValidation::GetValidationMessage;

Why using nsIConstraintValidation?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Ms2ger, could you answer to Mounir's question?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

er, nm

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 468393 [details] [diff] [review]
Patch v1

Thanks. (FTR, I talked about this bug with Mounir on IRC a while ago; I understood he was fine with it too after that.)

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin

Thanks.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/753feecdbd7c