Closed Bug 589975 Opened 9 years ago Closed 9 years ago
_Get Radio Update Value Missing Visitor shouldn't have a a Notify parameter
Given that the aNotify parameter is used for all radios in the radio group, it will not apply except for the caller.
Assignee: nobody → mounir.lamouri
blocking2.0: --- → final+
I don't understand, why is this safe? If removeElement is called with aNotify=false, then it's quite possibly because it's not safe to do notifications.
Comment on attachment 479605 [details] [diff] [review] Patch v1 Removing review request while waiting
(In reply to comment #2) > I don't understand, why is this safe? If removeElement is called with > aNotify=false, then it's quite possibly because it's not safe to do > notifications. I guess this comment applies for bug 589977 instead? IIRC, the reason of this bug is aNotify passed to the visitor doesn't really apply on all radio elements. That's what have been done for nsHTMLFormElement::UpdateValidity. Boris told me that assuming PR_TRUE was the best solution.
Comment on attachment 479605 [details] [diff] [review] Patch v1 Re-requesting per comment 4.
Attachment #479605 - Flags: review?(jonas) → review+
Target Milestone: --- → mozilla2.0b8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.