589975 - NS_GetRadioUpdateValueMissingVisitor shouldn't have a aNotify parameter

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Given that the aNotify parameter is used for all radios in the radio group, it will not apply except for the caller.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I don't understand, why is this safe? If removeElement is called with aNotify=false, then it's quite possibly because it's not safe to do notifications.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 479605 [details] [diff] [review]
Patch v1

Removing review request while waiting

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to comment #2)
> I don't understand, why is this safe? If removeElement is called with
> aNotify=false, then it's quite possibly because it's not safe to do
> notifications.

I guess this comment applies for bug 589977 instead?

IIRC, the reason of this bug is aNotify passed to the visitor doesn't really apply on all radio elements. That's what have been done for nsHTMLFormElement::UpdateValidity. Boris told me that assuming PR_TRUE was the best solution.

Comment 5

[Mounir Lamouri (:mounir)]

Comment on attachment 479605 [details] [diff] [review]
Patch v1

Re-requesting per comment 4.

Comment 6

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/0d88025a123f