590030 - Both success and error geolocation callbacks can be called

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Josh Matthews [:jdm]]

Consider a simple testcase:

  navigator.geolocation.getCurrentPosition(function(p) alert("woo!"), function(p) alert("boo!"), {timeout:5, maxAge:1});

When using the wifi location provider, this will cause both callbacks to be executed when the request is allowed. First the error will fire due to the timeout, but only after the geolocation retrieval has been initiated.  The alert spins the event loop, which happens to kick off the wifi monitor which is a sync proxy.  This triggers a geolocation update, so the success callback is triggered.

Comment 1

[Josh Matthews [:jdm]]

The easiest fix here is to not trigger the error callbacks until we've removed the request from the list of pending ones that the geolocator can update.

Comment 2

[Josh Matthews [:jdm]]

Attachment: Patch

Comment 3

[Doug Turner (:dougt)]

as always, thanks Josh!

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Still needs approval.

Comment 5

[Josh Matthews [:jdm]]

This patch has bitrotted a bit, for the record.

Comment 6

[Josh Matthews [:jdm]]

http://hg.mozilla.org/mozilla-central/rev/9fb7937e306d