590035 - Middle clicking tab bar with Menu Bar disabled doesn't open new tab

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[imradyurrad]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b5pre) Gecko/20100822 Minefield/4.0b5pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b5pre) Gecko/20100822 Minefield/4.0b5pre

When the menu bar's disabled, middle clicking on the tab bar no longer opens a new tab.

Reproducible: Always

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Should be easy, taking

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Mostly blocking because of bug 575248, and because I think we should be careful to restore all old tabstrip functionality.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

We need to generate the gecko middle click events for NC middle-clicks too. I don't think there's any reason to not always do that, so here's a patch.

Comment 4

[Jim Mathies [:jimm]]

Hmm, why does this fix this? I wouldn't think windows would be sending nc mouse events for the new client/content area. (it's not an nc area anymore.)

I'm mostly just curious, did you test this? My middle click on a tab closes it. Middle click on the tab bar area does nothing.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

That's because the empty area on the tabbar is considered NC area (to allow aero dragging/dbl clicking)

Comment 6

[:Felipe Gomes (needinfo for replies!)]

(In reply to comment #4)
> Hmm, why does this fix this? I wouldn't think windows would be sending nc mouse
> events for the new client/content area. (it's not an nc area anymore.)

I missed the last phrase, why do you mean it's not NC area anymore? That's what NS_MOZ_HITTEST is meant to return (I think) on the empty glass areas (e.g. the parts of the tabbar where there are no tabs)

Comment 7

[Jim Mathies [:jimm]]

(In reply to comment #6)
> (In reply to comment #4)
> > Hmm, why does this fix this? I wouldn't think windows would be sending nc mouse
> > events for the new client/content area. (it's not an nc area anymore.)
> 
> I missed the last phrase, why do you mean it's not NC area anymore? That's what
> NS_MOZ_HITTEST is meant to return (I think) on the empty glass areas (e.g. the
> parts of the tabbar where there are no tabs)

Ah, so we return the nc constant in WM_NCHITTEST and windows generates the appropriate mouse events. That explains why bug 574859 works on non-nc events. 

What about the middle nc double click message? Do we need that as well?

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 471266 [details] [diff] [review]
Patch

True, M double click is not used but should be supported

Comment 9

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch v2

Now with double click too

Comment 10

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/29c3f6e7c48e