590068 - Use search service to keep track of additional search params in about:home

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Marco Bonardo [:mak]]

this is a follow-up from bug 563723, once bug 587780 is fixed we can use search service to keep track of additional params.

Comment 1

[:Margaret Leibovic]

Gah, cc-ing myself changed the component. Changing it back.

Comment 2

[Matthew N. [:MattN]]

Attachment: Use "homepage" purpose for about:home

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 612637 [details] [diff] [review]
Use "homepage" purpose for about:home

Review of attachment 612637 [details] [diff] [review]:
-----------------------------------------------------------------

<3

now, if we could also add a full-size logo to each search engine... :p

Comment 4

[Marco Bonardo [:mak]]

why this didn't land yet?

Comment 5

[Marco Bonardo [:mak]]

ah I see, the dependency needs review.  Sorry for noise.

Comment 6

[Matthew N. [:MattN]]

Attachment: v.2 Use "homepage" purpose for about:home and update test

Update to reflect code movement to AboutHomeUtils and update test added in bug 587780.

Comment 7

[Matthew N. [:MattN]]

Thanks.

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/b061b91098b2

Try results from v.1: https://tbpl.mozilla.org/?tree=Try&rev=a799109407c4

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b061b91098b2