590258 - Reformat x86-on-x86_64 part of Linux UA string

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[[e-mail]]

Spinoff from bug 589353. We currently have "(X11, Linux x86 (x86_64), rv:...)". The nested parens are guaranteed to cause trouble, and very few people probably test against this particular case. For instance, our very own rv detection algorithm on geckoisgecko.org and https://developer.mozilla.org/en/Browser_Detection_and_Cross_Browser_Support breaks because of this.

We should say "x86 on x86_64" or "x86/x86_64" instead.

Comment 1

[rsx11m]

Right, the nested parentheses can be confusing, and in fact violate RFC 2616: http://asg.web.cmu.edu/rfc/rfc2616.html#sec-2.2

> "x86 on x86_64" or "x86/x86_64"

The "on" version is unambiguous, though the reverse (x86_64 on x86) unlikely, thus the second form shouldn't be a problem either.

Comment 2

[rsx11m]

> (correction to comment #1) and in fact violate RFC 2616:

Eh, maybe not - a comment can contain a comment and hence {"(" {"(" ")"} ")"}:

       comment        = "(" *( ctext | quoted-pair | comment ) ")"
       ctext          = <any TEXT excluding "(" and ")">

Comment 3

[[e-mail]]

Whether it violates it isn't relevant here; the fact that it breaks things IRL does.

Comment 4

[rsx11m]

Agreed.

Comment 5

[[e-mail]]

Attachment: patch

Comment 6

[[e-mail]]

http://hg.mozilla.org/mozilla-central/rev/a0c61c0145ff