Reformat x86-on-x86_64 part of Linux UA string

RESOLVED FIXED

Status

()

Core
Networking: HTTP
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dwitte@gmail.com, Assigned: dwitte@gmail.com)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Spinoff from bug 589353. We currently have "(X11, Linux x86 (x86_64), rv:...)". The nested parens are guaranteed to cause trouble, and very few people probably test against this particular case. For instance, our very own rv detection algorithm on geckoisgecko.org and https://developer.mozilla.org/en/Browser_Detection_and_Cross_Browser_Support breaks because of this.

We should say "x86 on x86_64" or "x86/x86_64" instead.

Comment 1

7 years ago
Right, the nested parentheses can be confusing, and in fact violate RFC 2616: http://asg.web.cmu.edu/rfc/rfc2616.html#sec-2.2

> "x86 on x86_64" or "x86/x86_64"

The "on" version is unambiguous, though the reverse (x86_64 on x86) unlikely, thus the second form shouldn't be a problem either.

Comment 2

7 years ago
> (correction to comment #1) and in fact violate RFC 2616:

Eh, maybe not - a comment can contain a comment and hence {"(" {"(" ")"} ")"}:

       comment        = "(" *( ctext | quoted-pair | comment ) ")"
       ctext          = <any TEXT excluding "(" and ")">
(Assignee)

Comment 3

7 years ago
Whether it violates it isn't relevant here; the fact that it breaks things IRL does.

Comment 4

7 years ago
Agreed.
(Assignee)

Comment 5

7 years ago
Created attachment 469257 [details] [diff] [review]
patch
Assignee: nobody → dwitte
Status: NEW → ASSIGNED
Attachment #469257 - Flags: superreview?(jst)
Attachment #469257 - Flags: review?(jst)

Updated

7 years ago
Attachment #469257 - Flags: superreview?(jst)
Attachment #469257 - Flags: superreview+
Attachment #469257 - Flags: review?(jst)
Attachment #469257 - Flags: review+
(Assignee)

Comment 6

7 years ago
http://hg.mozilla.org/mozilla-central/rev/a0c61c0145ff
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.