590274 - test-panel.testContentURLOption times out

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

test-panel.testContentURLOption times out.  This is a regression from bug 588225, and the cause is obvious: the test calls test.waitUntilDone() but never calls test.done().  Since it doesn't do anything asynchronously, though, it doesn't even need to call test.waitUntilDone() in the first place.

It's completely unclear why the problem didn't manifest before now.  It didn't show up in any previous testing.  Perhaps another test failure masked the problem?  If so, that would be very weird, since the other test failures we've been fixing for the 0.7 release have all been in other test scripts.

In any case, here's the trivial patch that resolves the problem, with extra context so you can see the whole function and the absence of both test.done() and asynchronicity.

Comment 1

[Dietrich Ayala (:dietrich)]

Comment on attachment 468771 [details] [diff] [review]
patch v1: fixes problem

r=me. next time please provide more lines of context in the patch.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #1)
> r=me. next time please provide more lines of context in the patch.

You betcha!

Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/b90bedb83525.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".