590292 - Crash at every startup of Mail with Lightning 1.1a1pre [@ calbasecomps.dll@0x1b42 ] (Windows) or [@ libcalbasecomps.so@0x60bd ] (Linux)

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

Steps to Reproduce:
1) create new profile using Mozilla/5.0 (Windows NT 6.1; rv:2.0b5pre) Gecko/20100824 Shredder/3.2a1pre
2) install Lightning 1.1a1pre (BuildID: 20100824040915)
3) restart

Actual Results:
Crash on startup. Several crash reports were submitted, e.g. <http://crash-stats.mozilla.com/report/index/bp-ca3ad313-f71e-4e6e-9628-10b952100824>

<http://crash-stats.mozilla.com/report/list?product=Thunderbird&query_search=signature&query_type=startswith&query=calbasecomps.dll&date=08-25-2010 23:59:59&range_value=1&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=&signature=calbasecomps.dll%400x1b42>

Comment 1

[u331436]

Problem confirmed on my side, WinXP and recent builds of SM2.1b1pre (20100820 to 20100825). 
Disabling lightning (latest comm-central nightly builds) makes seamonkey workable. With lightning enabled, crash happens as soon as the mail window is opened.

Comment 2

[Stefan Sitter [:ssitter]]

Regression range:
Works using Ltn 1.1a1pre (20100825035154) + Tb 3.2a1pre (20100819033932)
Fails using Ltn 1.1a1pre (20100825035154) + Tb 3.2a1pre (20100820183932)

Comment 3

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux i686; rv:2.0b5pre) Gecko/20100825 Lightning/1.1a1pre SeaMonkey/2.1b1pre - Build ID: 20100825010521

Had several crashes day before yesterday [@ libcalbasecomps.so@0x60bd ] which looks ominously like the Linux equivalent of this Windows bug, so I'm setting OS to All. At every start of MailNews except in safe mode. Didn't report them yet because I wanted to establish first which addon was the culprit. Here are the crash IDs:
bp-344b2e44-f436-4ceb-a9d8-1d2c32100825
bp-52355611-e0c7-49da-86b0-6b9de2100825
bp-2be20a4c-1ffe-4981-8cba-9d7ff2100825
bp-3bcc0db0-3bd9-4890-a0b3-512222100825
bp-5ffd8312-3794-466c-9bfd-17fae2100825

Comment 4

[Boying Lu]

I got a similar crash on OpenSolaris also.  I fount the root cause may be failed to load calModule.js.

I got following error in the terminal:
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "calAttachment is not defined" {file: "file:///export/home/brian/moz-ws/community/0811/thunderbird/mozilla/dist/bin/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calItemModule.js" line: 83}]' when calling method: [xpcIJSGetFactory::get]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]
************************************************************

Comment 5

[Boying Lu]

Attachment: patch

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 469824 [details] [diff] [review]
patch

I see these fixes are needed, but do they fix the crash?

Comment 7

[Daniel Kies]

(In reply to comment #6)
> Comment on attachment 469824 [details] [diff] [review]
> patch
> 
> I see these fixes are needed, but do they fix the crash?

I can confirm that Boying Lu's fix works for me on Windows.  

I downloaded the latest Lighting tinderbox build, edited the three .js files Boying changed in his patch manually on my machine, updated Seamonkey to the latest trunk nightly, and restarted.  Result: no crash when starting Seamonkey mailnews (which had been crashing since the 20100820 nightlies).

Thank you, Boying.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/7b5189c2cf28>
-> FIXED

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Ok, so lets take this fix and see what happens. Please reopen if this crash persists.

Comment 10

[Stefan Sitter [:ssitter]]

Verified fixed using Lightning 1.1a1pre (BuildID: 20100829013809) with Mozilla/5.0 (Windows NT 6.1; rv:2.0b5pre) Gecko/20100827 Thunderbird/3.2a1pre (BuildID: 20100827033932).

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/4bade4be4f4e>

a=philipp