Closed Bug 590302 Opened 15 years ago Closed 15 years ago

Crash [@ nsTextControlFrame::CalcIntrinsicSize] on print preview with textarea, position:fixed

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b5
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: martijn.martijn, Assigned: ehsan.akhgari)

References

Details

(4 keywords)

Crash Data

Attachments

(2 files)

testcase
189 bytes, application/xhtml+xml
Details
Patch (v1)
2.84 KB, patch
roc
: review+
Details | Diff | Splinter Review
Attached file testcase —
See testcase, which crashes current trunk build on print preview. This regressed between 2010-06-03 and 2010-06-14. I can look for a more narrow regression range, if wanted. http://crash-stats.mozilla.com/report/index/566c4ad2-86c5-46b8-a1c8-c6e482100824 0 xul.dll nsTextControlFrame::CalcIntrinsicSize layout/forms/nsTextControlFrame.cpp:302 1 xul.dll nsTextControlFrame::ComputeAutoSize layout/forms/nsTextControlFrame.cpp:497
Same range as Bug 578604, but different sig. Regression window: Works: http://hg.mozilla.org/mozilla-central/rev/21f0727c27a6 Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100605 Minefield/3.7a5pre ID:20100605111313 Fails: http://hg.mozilla.org/mozilla-central/rev/2875f9a693ae Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100605 Minefield/3.7a5pre ID:20100605135617 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=21f0727c27a6&tochange=2875f9a693ae
Thanks for the regression range, Alice!
Blocks: 534785
blocking2.0: --- → ?
Assignee: nobody → ehsan
This is basically another instance of bug 578604. A fix to bug 584564 should fix this issue as well, but I'm looking for the possibility of a wallpaper fix for this bug right now...
Keywords: assertion
Attached patch Patch (v1) — — Splinter Review
This patch basically extends the wallpaper fix from bug 578604 to other GetFirstChild call sites in nsTextControlFrame.
Attachment #468884 - Flags: review?(roc)
Attachment #468884 - Flags: approval2.0?
Attachment #468884 - Flags: approval2.0?
http://hg.mozilla.org/mozilla-central/rev/d3e4116d4167
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b5
Verified fixed, using: Mozilla/5.0 (Windows NT 6.1; rv:2.0b6pre) Gecko/20100909 Firefox/4.0b6pre
Status: RESOLVED → VERIFIED
is Bug 595377 a possible regression from this?
No, I think bug 595377 is the same as bug 592835.
Crash Signature: [@ nsTextControlFrame::CalcIntrinsicSize]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: