Closed Bug 590325 Opened 9 years ago Closed 9 years ago

TM: Global Object created in CentralizedAdminPrefManagerInit needs its own compartment

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- final+

People

(Reporter: gwagner, Assigned: gal)

References

Details

(Whiteboard: fixed-in-tracemonkey, hardblocker)

Attachments

(5 files)

in nsJSConfigTriggers.cpp line 163
Blocks: 558861
Attached patch patchSplinter Review
Assignee: general → gal
Comment on attachment 468845 [details] [diff] [review]
patch

Gregor, please test.
Attachment #468845 - Flags: review?(mrbkap)
Attachment #468845 - Flags: review?(mrbkap) → review+
http://hg.mozilla.org/tracemonkey/rev/27194100cb0d
Whiteboard: fixed-in-tracemonkey
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
This got merged out or something because it's not in mozilla-central.
Blocks: 595522
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: fixed-in-tracemonkey
Rob, do you know what the status of this is? Per comment #5 and the comments in bug 595522, this code is no longer in the tree.
Just added an author/commit message.
/fasthome/mikew/moz/mozilla-central/extensions/pref/autoconfig/src/nsJSConfigTriggers.cpp: In function ‘nsresult CentralizedAdminPrefManagerInit()’:
/fasthome/mikew/moz/mozilla-central/extensions/pref/autoconfig/src/nsJSConfigTriggers.cpp:165:78: error: no matching function for call to ‘JSAutoEnterCompartment::JSAutoEnterCompartment(JSContext*&, JSObject*&)’
../../../../dist/include/jsapi.h:1011:5: note: candidates are: JSAutoEnterCompartment::JSAutoEnterCompartment()
../../../../dist/include/jsapi.h:1007:1: note:                 JSAutoEnterCompartment::JSAutoEnterCompartment(const JSAutoEnterCompartment&)

Looks like we need a new patch.
Attached patch Possibe patch 1Splinter Review
Attached patch Possible patch 2Splinter Review
I've attached 2 possible patches that fix the issue (taken from bug 595522) - I don't pretend to understand what the code does, so I have no idea if either is the correct way to do this - but either patch fixes the issue for me ...
Mhm, looks like this fell off the radar. Thanks James.
blocking2.0: --- → final+
Attached patch patchSplinter Review
Attachment #505066 - Flags: review?(mrbkap)
review ping
Attachment #505066 - Flags: review?(mrbkap) → review+
http://hg.mozilla.org/tracemonkey/rev/245900601090
Whiteboard: fixed-in-tracemonkey
(In reply to comment #15)
> http://hg.mozilla.org/tracemonkey/rev/6852eeba1dd5

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1295598296.1295598523.16147.gz

../../../../../extensions/pref/autoconfig/src/nsJSConfigTriggers.cpp:166: error: 'ccx' was not declared in this scope
Yeah, its one of those days.

http://hg.mozilla.org/tracemonkey/rev/143179160c52
Whiteboard: fixed-in-tracemonkey → fixed-in-tracemonkey, hardblocker
You need to log in before you can comment on or make changes to this bug.