590325 - TM: Global Object created in CentralizedAdminPrefManagerInit needs its own compartment

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gregor Wagner [:gwagner]]

in nsJSConfigTriggers.cpp line 163

Comment 1

[Andreas Gal :gal]

Attachment: patch

Comment 2

[Andreas Gal :gal]

Comment on attachment 468845 [details] [diff] [review]
patch

Gregor, please test.

Comment 3

[Gregor Wagner [:gwagner]]

http://hg.mozilla.org/tracemonkey/rev/27194100cb0d

Comment 4

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/27194100cb0d

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This got merged out or something because it's not in mozilla-central.

Comment 6

[Dietrich Ayala (:dietrich)]

Rob, do you know what the status of this is? Per comment #5 and the comments in bug 595522, this code is no longer in the tree.

Comment 7

[Michael Wu [:mwu]]

Attachment: hg patch ready patch

Just added an author/commit message.

Comment 8

[Michael Wu [:mwu]]

/fasthome/mikew/moz/mozilla-central/extensions/pref/autoconfig/src/nsJSConfigTriggers.cpp: In function ‘nsresult CentralizedAdminPrefManagerInit()’:
/fasthome/mikew/moz/mozilla-central/extensions/pref/autoconfig/src/nsJSConfigTriggers.cpp:165:78: error: no matching function for call to ‘JSAutoEnterCompartment::JSAutoEnterCompartment(JSContext*&, JSObject*&)’
../../../../dist/include/jsapi.h:1011:5: note: candidates are: JSAutoEnterCompartment::JSAutoEnterCompartment()
../../../../dist/include/jsapi.h:1007:1: note:                 JSAutoEnterCompartment::JSAutoEnterCompartment(const JSAutoEnterCompartment&)

Looks like we need a new patch.

Comment 9

[James Pearson]

Attachment: Possibe patch 1

Comment 10

[James Pearson]

Attachment: Possible patch 2

I've attached 2 possible patches that fix the issue (taken from bug 595522) - I don't pretend to understand what the code does, so I have no idea if either is the correct way to do this - but either patch fixes the issue for me ...

Comment 11

[Andreas Gal :gal]

Mhm, looks like this fell off the radar. Thanks James.

Comment 12

[Andreas Gal :gal]

Attachment: patch

Comment 13

[Andreas Gal :gal]

review ping

Comment 14

[Andreas Gal :gal]

http://hg.mozilla.org/tracemonkey/rev/245900601090

Comment 15

[Andreas Gal :gal]

http://hg.mozilla.org/tracemonkey/rev/6852eeba1dd5

Comment 16

[Alex Vincent [:WeirdAl]]

(In reply to comment #15)
> http://hg.mozilla.org/tracemonkey/rev/6852eeba1dd5

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1295598296.1295598523.16147.gz

../../../../../extensions/pref/autoconfig/src/nsJSConfigTriggers.cpp:166: error: 'ccx' was not declared in this scope

Comment 17

[Andreas Gal :gal]

Yeah, its one of those days.

http://hg.mozilla.org/tracemonkey/rev/143179160c52

Comment 18

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/245900601090
http://hg.mozilla.org/mozilla-central/rev/6852eeba1dd5
http://hg.mozilla.org/mozilla-central/rev/143179160c52