Closed
Bug 590325
Opened 14 years ago
Closed 14 years ago
TM: Global Object created in CentralizedAdminPrefManagerInit needs its own compartment
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: gwagner, Assigned: gal)
References
Details
(Whiteboard: fixed-in-tracemonkey, hardblocker)
Attachments
(5 files)
|
1.16 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
|
1.11 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.14 KB,
patch
|
Details | Diff | Splinter Review | |
|
841 bytes,
patch
|
Details | Diff | Splinter Review | |
|
1.19 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
in nsJSConfigTriggers.cpp line 163
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: general → gal
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 468845 [details] [diff] [review]
patch
Gregor, please test.
Attachment #468845 -
Flags: review?(mrbkap)
|
||
Updated•14 years ago
|
Attachment #468845 -
Flags: review?(mrbkap) → review+
|
Reporter | |
Comment 3•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
This got merged out or something because it's not in mozilla-central.
|
||
Comment 6•14 years ago
|
||
Rob, do you know what the status of this is? Per comment #5 and the comments in bug 595522, this code is no longer in the tree.
|
||
Comment 7•14 years ago
|
||
Just added an author/commit message.
|
|
||
Comment 8•14 years ago
|
||
/fasthome/mikew/moz/mozilla-central/extensions/pref/autoconfig/src/nsJSConfigTriggers.cpp: In function ‘nsresult CentralizedAdminPrefManagerInit()’:
/fasthome/mikew/moz/mozilla-central/extensions/pref/autoconfig/src/nsJSConfigTriggers.cpp:165:78: error: no matching function for call to ‘JSAutoEnterCompartment::JSAutoEnterCompartment(JSContext*&, JSObject*&)’
../../../../dist/include/jsapi.h:1011:5: note: candidates are: JSAutoEnterCompartment::JSAutoEnterCompartment()
../../../../dist/include/jsapi.h:1007:1: note: JSAutoEnterCompartment::JSAutoEnterCompartment(const JSAutoEnterCompartment&)
Looks like we need a new patch.
|
||
Comment 9•14 years ago
|
||
|
|
||
Comment 10•14 years ago
|
||
I've attached 2 possible patches that fix the issue (taken from bug 595522) - I don't pretend to understand what the code does, so I have no idea if either is the correct way to do this - but either patch fixes the issue for me ...
|
|
Assignee | |
Comment 11•14 years ago
|
||
Mhm, looks like this fell off the radar. Thanks James.
|
|
Assignee | |
Updated•14 years ago
|
blocking2.0: --- → final+
|
|
Assignee | |
Comment 12•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #505066 -
Flags: review?(mrbkap)
|
|
Assignee | |
Comment 13•14 years ago
|
||
review ping
|
|
||
Updated•14 years ago
|
Attachment #505066 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 14•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Comment 15•14 years ago
|
||
|
||
Comment 16•14 years ago
|
||
(In reply to comment #15)
> http://hg.mozilla.org/tracemonkey/rev/6852eeba1dd5
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1295598296.1295598523.16147.gz
../../../../../extensions/pref/autoconfig/src/nsJSConfigTriggers.cpp:166: error: 'ccx' was not declared in this scope
|
|
Assignee | |
Comment 17•14 years ago
|
||
Yeah, its one of those days.
http://hg.mozilla.org/tracemonkey/rev/143179160c52
|
||
Updated•14 years ago
|
Whiteboard: fixed-in-tracemonkey → fixed-in-tracemonkey, hardblocker
|
||
Comment 18•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/245900601090
http://hg.mozilla.org/mozilla-central/rev/6852eeba1dd5
http://hg.mozilla.org/mozilla-central/rev/143179160c52
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•