590335 - add "turn d2d off" pref

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Joe Drew (not getting mail)]

We need a new about:config pref that makes it a lot easier to force off Direct2D.

Comment 1

[Joe Drew (not getting mail)]

Attachment: add gfx.direct2d.disabled pref

This patch adds the pref gfx.direct2d.disabled, which is set to false by default, but can be toggled to true to disable the automatic use of d2d. Users can still use mozilla.widget.render-mode to select a rendering mode manually.

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 469117 [details] [diff] [review]
add gfx.direct2d.disabled pref

># HG changeset patch
># Parent cca13a1397f8d70257b151ac5cf5dfb0dbcac1ba
>diff --git a/gfx/thebes/gfxWindowsPlatform.cpp b/gfx/thebes/gfxWindowsPlatform.cpp
>--- a/gfx/thebes/gfxWindowsPlatform.cpp
>+++ b/gfx/thebes/gfxWindowsPlatform.cpp
>@@ -222,17 +222,22 @@ gfxWindowsPlatform::gfxWindowsPlatform()
>     ::GetVersionExA(&versionInfo);
>     bool isVistaOrHigher = versionInfo.dwMajorVersion >= 6;
> 
> #ifdef CAIRO_HAS_D2D_SURFACE
>     NS_RegisterMemoryReporter(new D2DCacheReporter());
>     NS_RegisterMemoryReporter(new D2DVRAMReporter());
>     mD2DDevice = NULL;
> 
>-    if (isVistaOrHigher) {
>+    PRBool d2dDisabled = PR_FALSE;
>+    nsresult rv = pref->GetBoolPref("gfx.direct2d.disabled", &d2dDisabled);
>+    if (NS_FAILED(rv))
>+        d2dDisabled = PR_FALSE;
I wonder if we really need this, logic would dictate GetBoolPref doesn't touch d2dDisabled if it fails.

Comment 3

[Joe Drew (not getting mail)]

http://hg.mozilla.org/mozilla-central/rev/5d174cb918fe