590353 - Do not try to reset the default value if the element value isn't different from the value attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Test case

If during an onclick handler, the value of a checkbox (very likely a radio too) is changed, the checkbox will not be checked.

The reason seems to be because we go to ::SetValueInternal and then, because it's not a text control, we call ::SetAttr (then ::AfterSetAttr). And, because the dirty value flag is false, the value is reseted to the default value.

An easy fix would be to not reset the element to the default value if the checkedness flag is true but that would probably cause some minor differences with the current specifications.

Attached, a test case. When clicking on the checkbox, the expected behavior is to see "value: 0 checked: true" in the textarea (Firefox 3.6 does that). With Firefox 4 b4, it's "value: 0 checked: false".

Comment 1

[Johnny Stenback (:jst)]

Blocking and cc:ing Bret who found this bug! :)

Comment 2

[Bret Reckard]

My girlfriend Lindsay found this bug, I was merely the messenger.

Comment 3

[Mounir Lamouri (:mounir)]

Another test case has been written by Boris on bug 592228:
https://bugzilla.mozilla.org/attachment.cgi?id=470761

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 471724 [details] [diff] [review]
Patch v1

Ok, r+, although this code is getting harder and harder to understand.

Comment 7

[Mounir Lamouri (:mounir)]

Thank you Bret and Lindsay for reporting this bug.
This will be fixed in Firefox 4 beta 6.

Push:
http://hg.mozilla.org/mozilla-central/rev/89977f3a769c