59036 - Long channel topic causes chatzilla to think it has a bigger window

Status: VERIFIED FIXED

(Other Applications :: ChatZilla, defect, P3)

Description

[Jacob Steenhagen]

If a topic on IRC is really long (longer than the space alloted for it in the
status bar) and the status bar is turned on, it seems to cause Chatzilla a
little heartache.

If you join a channel that has a really long topic (with your status bar shown),
it will cause the userlist to be wider than normal.  Also, all text that's typed
in will not wrap properly at the window border.

I suspect these problems are directly related in that when chatzilla places the
title is the statusbar it uses a nowrap single line.  The rest of the window is
then resized around this, but without a horizontal scrollbar.

Comment 1

[Erich 'Ricky' Iseli]

Not only on Win2000, also on Win98 and I guess this happens also on other OS's

Comment 2

[Daniel Brooks [:db48x]]

Fix is to add 'crop="right"' attribute to the <text/> node at line 273. I can
post a real patch if my tree finishes updating...

Comment 3

[Daniel Brooks [:db48x]]

Attachment: simple fix, thanks to SAdvani for mentioning it in front of me, and to Ben Goodger who helped me fix a similar problem some time ago. :)

Comment 4

[Daniel Brooks [:db48x]]

note that this bug still occurs if the window is smaller than the total width of
the other information at the bottom of the screen, so adding crop="right" to
them wouldn't hurt, but that is a pretty darn small window, so is it worth
bothering?

Comment 5

[Boris Zbarsky [:bzbarsky]]

r=bzbarsky on that patch, but Daniel says he's going to attach one that fixes
all the fields, not just topic.

Comment 6

[Daniel Brooks [:db48x]]

Since fixing all the text fields requires modifing all the surrounding boxes,
I'd say it's not really worth the bother unless it's changed to use grids (I
can't promise it'd work 100% the same as it does now though. it's a weird
layout). I'd say file a low priority bug on it. If it doesn't get fixed it won't
be the end of the world.

Comment 7

[Robert Ginda]

Thanks for letting me know about this. I'm planning a large chatzilla update
RSN, and will include this fix.

Comment 8

[Robert Ginda]

superbug checked in, mass marking all dependents fixed.

Comment 9

[Samuel Sieb]

verified with latest build