590402 - [stats] Add an option to output IPs (for Friends of Brazil Guy)

Status: RESOLVED FIXED

(Camino Graveyard :: General, enhancement)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

When we get giant ping days, we have to go through and look for giant-ping IPs that aren't already in $badips.  We should just add an option (like "--dumpIPs") to generate_update_statistics to output them for us.

grep "24/Aug" caminobrowser.org-ssl_log | grep " /update-check?os=" | cut -d " " -f 1 | sort | uniq -c | sort -r > IPlist.txt

is what I used tonight as the shell command; let me know if you have something different/better you use.

I'll see if I can figure out how to add option/flag support to the current script without breaking everything ;-)

Comment 1

[Stuart Morgan]

Attachment: proposed fix

This adds an initial command argument (rather than having a flag that makes everything else behave differently), so it will require a minor change to anything built on top of this script.

Please try this out, and let me know if it does what you want, if you want a different format, different arguments, etc. I'm deliberately not saying more to make sure the usage message is reasonable ;)

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Can you unbitrot this when you get a chance (and when it's likely to not be broken soon after by other work in bug 637091, thereby continuing the cycle of making more work for you)?  The first hunk fails to apply now.

Comment 3

[Stuart Morgan]

Yeah, sorry. I was planning on doing that yesterday but didn't get to it. Coming right up...

Comment 4

[Stuart Morgan]

Attachment: un-bit-rotted

Here you go; this will apply against ToT.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 524135 [details] [diff] [review]
un-bit-rotted

Per irc, it would be useful to have the dates for the given pings, perhaps best displayed as tabular data.  Otherwise, it seems to do what I want.

Comment 6

[Stuart Morgan]

Attachment: v3

Outputs a table with date-labelled columns.

Comment 7

[Stuart Morgan]

Landed http://hg.mozilla.org/camino/rev/6006af0e127d

(Don't forget to update your wrapper to add the "counts" command)