Closed Bug 590415 Opened 14 years ago Closed 7 years ago

Intermittent failure in layout/reftests/bugs/368020-1.html | image comparison (==)

Categories

(Core :: Graphics: ImageLib, defect, P3)

7 Branch
x86
Windows XP
defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: philor, Unassigned)

References

Details

(Keywords: intermittent-failure, regression, Whiteboard: [test disabled])

Attachments

(1 obsolete file)

Attached file reftest log (obsolete) —
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1282605029.1282609742.21400.gz
WINNT 5.2 mozilla-central debug test reftest on 2010/08/23 16:10:29
s: win32-slave07

REFTEST TEST-UNEXPECTED-FAIL | file:///e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-reftest/build/reftest/tests/layout/reftests/bugs/368020-1.html |
...
REFTEST number of differing pixels: 32996

The log is unexciting, since it's just "the background image is totally missing," other than the excitement of that sounding a whole lot like bug 590410, which I just filed.
It is possible for this bug to have been caused by enabling image discarding.  I'll test a patch on the try server which disables image discarding, and will see if this bug happens with image discarding disabled.
Try run for edbc7c5ea1c6 is complete.
Detailed breakdown of the results available here:
    http://tbpl.mozilla.org/?tree=Try&rev=edbc7c5ea1c6
Results:
    success: 5
    warnings: 1
Total buildrequests: 6
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-edbc7c5ea1c6
Summary: Intermittent failure in layout/reftests/bugs/368020-1.html → Intermittent failure in layout/reftests/bugs/368020-1.html | image comparison (==)
OK, the try server job I pushed in comment 122 definitely shows that this bug is caused by image discarding being turned on.

He also told me that jlebar has recently done something which could be responsible for the increase in the frequency of this orange.

Do any of you guys have any idea how we can proceed with diagnosing/fixing this bug?  (Note that it only seems to be happening on WinXP)
Blocks: 563088
Component: Layout → ImageLib
Keywords: regression
QA Contact: layout → imagelib
OS: Windows Server 2003 → Windows XP
Images are discarded after 10-20s, rather than 120-240s, due to bug 664290.  If this only happens when image discarding is off, I'd normally suspect that change would have affected this orange's frequency.

But that change landed on m-c on 2011-06-22, and this test seems to have gone crazy starting on 2011-07-21.  That corresponds to bug 666352 and bug 672578.  My guess is 666352 would matter more here.

I'll have a look at what this test is doing...
The difference is in the rightmost border in the testcase.  In img 1 (the reference?), the pixel at the bottom left of each dot in the RHS border has value (225, 225, 0), but in the bad image, the pixel has value (226, 226, 0).

Since this happens so frequently, let's figure out whether either of these two bugs is causing the issue by backing each one out individually and running a bunch of tests, as you did in comment 122.
Parent: comment 185.

I observed the failure with both candidate bugs backed out [1], so I suspect that neither bug 666352 nor bug 672578 has to do with this failure.

I did not observe the failure with bug 666352 backed out and bug 672578 left in [2], which is strange.  But maybe I just got lucky.  I'll kick some more tests to be sure.

[1] http://hg.mozilla.org/try/rev/e5bb510510d4
[2] http://hg.mozilla.org/try/rev/cfb490f138b5
Assignee: nobody → netzen
Parent: comment 196.

I haven't seen this failure on try after 17 runs with bug 666352 backed out and bug 672578 left in.

I don't know what to make of this.  Both bugs backed out yields the failure, but when I back out just one, it stops failing?  That's weird...
Bowed to reality and marked it as random on WinXP in http://hg.mozilla.org/integration/mozilla-inbound/rev/c0b90308926a, so if anyone ever goes back to looking at it, they'll need to revert that.
Comment on attachment 468945 [details]
reftest log

Convenient that what I filed the bug about never happened again, so it doesn't matter so much that it got hijacked.
Attachment #468945 - Attachment is obsolete: true
Whiteboard: [orange] → [orange][test disabled]
Whiteboard: [orange][test disabled] → [test disabled]
Assignee: netzen → nobody
Version: Trunk → 7 Branch
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: