Closed Bug 590429 Opened 10 years ago Closed 10 years ago

TestSTSParser.cpp failed to build with Sun Studio compiler

Categories

(Core :: DOM: Core & HTML, defect)

x86
iOS 3
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

References

Details

Attachments

(1 file, 1 obsolete file)

"/export/home/moz/tools/ff_slave/mozilla-central-solaris-x86/build/netwerk/test/TestSTSParser.cpp", line 80: Error: Trailing comma in a parameter list.
"/export/home/moz/tools/ff_slave/mozilla-central-solaris-x86/build/netwerk/test/TestSTSParser.cpp", line 87: Error: Trailing comma in a parameter list.
"/export/home/moz/tools/ff_slave/mozilla-central-solaris-x86/build/netwerk/test/TestSTSParser.cpp", line 89: Error: Trailing comma in a parameter list.
"/export/home/moz/tools/ff_slave/mozilla-central-solaris-x86/build/netwerk/test/TestSTSParser.cpp", line 102: Error: Trailing comma in a parameter list.

Quotation from
http://forums.sun.com/thread.jspa?messageID=9367375#9367375

The C99 Standard says in the "Constraints" part of section 6.10.3, "there shall be more arguments in the invocation than there are parameters in the macro definition (excluding the ...)."

You can have a fixed argument in the macro definition
#define debug(arg1, ...) <something>
but you must have at least 2 arguments in each invocation.

if you want to be able to invoke the macro with one argument, the macro definition cannot have any fixed arguments.
Attached patch patch (obsolete) — Splinter Review
Attachment #468969 - Flags: review?(sstamm)
Comment on attachment 468969 [details] [diff] [review]
patch

Thanks for catching that, fix looks good.
Attachment #468969 - Flags: review?(sstamm) → review+
Attached patch patch v2Splinter Review
The previous patch breaks gcc 4.3.
Should change ##__VA_ARGS__ to __VA_ARGS__.
Attachment #468969 - Attachment is obsolete: true
Attachment #469418 - Flags: review?(sstamm)
Comment on attachment 469418 [details] [diff] [review]
patch v2

Confirmed works just fine with GCC 4.3.
Attachment #469418 - Flags: review?(sstamm) → review+
http://hg.mozilla.org/mozilla-central/rev/8f5523c9a830
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
OS: OpenSolaris → iOS 3
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.