590549 - Favicon missing from items in History tab within AwesomeScreen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:2.0b5pre) Gecko/20100824 Namoroka/4.0b5pre Fennec/2.0a1pre

Rather than the default icon being present for listed items, there simply exists an empty space to the left.

STR:
1. Visit any page
2. Check the History tab from within the AwesomeScreen

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch add the default favicon if there is no favicon but it seems like we're not saving the favicon when we're visiting a website (I think the one that appears are related to Firefox Sync)

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

The favicon (if not set thought a DOMLinkAdded) is not saved and so many sites apppear in the views of the awesome panel without any icons. (argh!)

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 469463 [details] [diff] [review]
Patch v0.2

This is the right fix?

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Obviously no!
This one should be good

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/f8c5fab65ec6

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100830 Namoroka/4.0b5pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100830 Namoroka/4.0b5pre Fennec/2.0a1pre