Closed Bug 590549 Opened 11 years ago Closed 11 years ago

Favicon missing from items in History tab within AwesomeScreen

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
All
defect
Not set
normal

Tracking

(fennec2.0b2+)

VERIFIED FIXED
Tracking Status
fennec 2.0b2+ ---

People

(Reporter: aaronmt, Assigned: vingtetun)

Details

Attachments

(1 file, 2 obsolete files)

Mozilla/5.0 (Android; Linux armv7l; rv:2.0b5pre) Gecko/20100824 Namoroka/4.0b5pre Fennec/2.0a1pre

Rather than the default icon being present for listed items, there simply exists an empty space to the left.

STR:
1. Visit any page
2. Check the History tab from within the AwesomeScreen
Attached patch Patch (obsolete) — Splinter Review
The patch add the default favicon if there is no favicon but it seems like we're not saving the favicon when we're visiting a website (I think the one that appears are related to Firefox Sync)
Attached patch Patch v0.2 (obsolete) — Splinter Review
The favicon (if not set thought a DOMLinkAdded) is not saved and so many sites apppear in the views of the awesome panel without any icons. (argh!)
Assignee: nobody → 21
Attachment #469449 - Attachment is obsolete: true
Attachment #469463 - Flags: review?(mark.finkle)
tracking-fennec: --- → 2.0b2+
Comment on attachment 469463 [details] [diff] [review]
Patch v0.2

This is the right fix?
Attached patch PatchSplinter Review
Obviously no!
This one should be good
Attachment #469463 - Attachment is obsolete: true
Attachment #469463 - Flags: review?(mark.finkle)
Attachment #469612 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/f8c5fab65ec6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100830 Namoroka/4.0b5pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100830 Namoroka/4.0b5pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.