590560 - valgrind invalid read in PinStackObjects

Status: RESOLVED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect)

Description

[Tommy Reilly]

==89279== Invalid read of size 4
==89279==    at 0x45B8B: MMgc::ZCT::PinStackObjects(void const*, unsigned long) (GCObject.h:253)
==89279==    by 0x45C1C: MMgc::ZCT::DoPinProgramStack(void*, void*) (ZCT.cpp:588)
==89279==    by 0x4162: CallWithRegistersSaved2(void (*)(void*, void*), void*, void*) (PosixPortUtils.cpp:298)
==89279==    by 0x4665: VMPI_callWithRegistersSaved(void (*)(void*, void*), void*) (MMgcPortMac.cpp:264)
==89279==    by 0x45CB4: MMgc::ZCT::Reap(bool) (ZCT.cpp:337)
==89279==    by 0x46216: MMgc::ZCT::AddSlow(MMgc::RCObject*) (ZCT.cpp:259)
==89279==    by 0x95021: avmplus::String::createDynamic(MMgc::GC*, void const*, int, avmplus::String::Width, bool, int) (ZCT-inlines.h:68)
==89279==    by 0x979F8: avmplus::String::createLatin1(avmplus::AvmCore*, char const*, int, avmplus::String::Width, bool) (StringObject.cpp:547)
==89279==    by 0x5045A: avmplus::AvmCore::newStringLatin1(char const*, int) (AvmCore.cpp:3888)
==89279==    by 0x825E0: avmplus::MathUtils::convertIntegerToStringRadix(avmplus::AvmCore*, long, int, avmplus::MathUtils::UnsignedTreatment) (MathUtils.cpp:725)
==89279==    by 0x50834: avmplus::AvmCore::string(int) (AvmCore.cpp:2309)
==89279==    by 0x1E613FB: ???
==89279==  Address 0x1dd0eec is not stack'd, malloc'd or (recently) free'd
==89279== 

We call Pin which reads composite which is 0 (because no error generated for write).   Probably just need a suppression for PinStackObjects or define the composite field for deleted objects

Comment 1

[Tommy Reilly]

changeset:   4969:ddb50ee032fb

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

(In reply to comment #1)
> changeset:   4969:ddb50ee032fb

In Tommy's user repository, that is (as opposed to TR):

http://asteam.macromedia.com/hg/users/treilly/tr-valgrind/rev/4969