590602 - Support input method changing in Fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ayan Shah[:ashah]]

Right now, there is no way to change, from inside Fennec, the type of keyboard that I want to use.
It would be good if the user can choose different keyboards(input methods) from inside the Fennec browser. The way Android browser does it right now is to hold the tap on a text field to get a context menu, which gives you the option to choose your input method type. The way to test it right now is to use Swype on android.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Matt, we'll need a backend API to trigger the input method selection. Brad is looking/filing that

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch v1

Oops. I'm stealing, but I needed to test. This applies on top of the patch in bug 609696. It doesn't make this work for chrome textboxes, but I figured that can be done in bug 585875.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch v2

Updated to new input picker patch.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

reassigned since Wes is patching

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 488924 [details] [diff] [review]
Patch v2


>diff --git a/chrome/content/browser.xul b/chrome/content/browser.xul

>         <richlistbox id="context-commands" onclick="ContextHelper.hide();" flex="1">
>           <richlistitem class="context-command" id="context-copy" type="copy" onclick="ContextCommands.copy();">
>             <label value="&copy.label;"/>
>           </richlistitem>
>+#ifdef ANDROID
>+          <richlistitem class="context-command" id="context-select-input" type="textfield" onclick="ContextCommands.selectInput();">
>+            <label value="&inputMethod.label;"/>
>+          </richlistitem>
>+#endif

id="context-inputmethod" type="input-text"

When you unbitrot this patch, make sure this item ends up at the bottom of the context menu for textbox items

>diff --git a/chrome/content/content.js b/chrome/content/content.js

>+        if (elem instanceof HTMLInputElement && elem.mozIsTextField(true)) {
>+          state.types.push("textfield");
>+        }

Let not add this here. Instead just add "input-text" to the json.types here:

http://hg.mozilla.org/mobile-browser/rev/e634cc4a8c35#l1.19

This was added by Brubeck's copy/paste patch

>diff --git a/locales/en-US/chrome/browser.dtd b/locales/en-US/chrome/browser.dtd
>+<!ENTITY inputMethod.label           "Select Input Method">
>+
> <!ENTITY selectHelper.emptytext      "Filter List">
>\ No newline at end of file

Make sure we have blank lines at end of files

r-, but close

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Patch v3

Adds this for chrome textboxes. Will try to do content in bug 611741.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/8c498f19a152

Comment 9

[timeless]

http://hg.mozilla.org/mobile-browser/rev/b48649e29148

Comment 10

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101115 Namoroka/4.0b8pre Fennec/4.0b3pre

Comment 11

[Ayan Shah[:ashah]]

https://litmus.mozilla.org/show_test.cgi?id=12692