590678 - Add tests for syntax errors in Reflect.parse()

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, defect)

Description

[Alex Vincent [:WeirdAl]]

In glancing over the patch for bug 533784, I don't see any tests for syntax errors in the src argument of Reflect.parse().  I'm hoping one of two things will happen:

(1) A syntax error will be thrown with file name & line number, which I can catch, or
(2) Reflect.parse returns a special value indicating "I couldn't parse this, due to a syntax error at ..."

Comment 1

[Dave Herman [:dherman]]

It's #1. I've added this information to the docs:

https://developer.mozilla.org/en/SpiderMonkey/Parser_API#parse%28string.5b.2c_string.3dnull.5b.2c_number.3d1.5d.5d%29

You're right, there should be tests for this.

Dave

Comment 2

[Alex Vincent [:WeirdAl]]

Looks like this check-in took you most of the way:
http://hg.mozilla.org/mozilla-central/rev/fb5b64e975c9

So we would just need to test "with file name & line number".