590792 - Make VectorImage::ExtractFrame() return an un-animated VectorImage

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Daniel Holbert [:dholbert]]

Quoting VectorImage::ExtractFrame() from my patch for bug 276431:
(attachment 469209 [details] [diff] [review])
>+  // XXXdholbert This method also doesn't actually freeze animation in the
>+  // returned imgIContainer, because it shares our helper-document. If that's
>+  // important, we'll need to duplicate the helper-document, or rasterize to a
>+  // RasterImage and return that instead.

roc suggests that we duplicate the helper-doc in bug 276431 comment 161. Filing this bug on doing that (or something equivalent).

Comment 1

[Seth Fowler [:seth] [:s2h]]

Bug 808189 involves a reworking of the implementation of ExtractImage, and this issue will be taken care of there.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Sorry, ExtractFrame, not ExtractImage.

Comment 3

[Seth Fowler [:seth] [:s2h]]

Sorry, actually bug 826093 is taking care of this.

Comment 4

[Seth Fowler [:seth] [:s2h]]

This is done. The solution is that clipping an image is now handled by ClippedImage and freezing the animation of an image is now handled by FrozenImage, so you can get either or both of those behaviors as required. ExtractFrame no longer exists.