590804 - Locking Disk Cache Size to 250MB

Status: RESOLVED FIXED

(Testing :: Talos, defect, P1)

Description

[Byron Milligan [:byronm]]

We are close to landing a patch that determines the size of the user's disk cache based on how much disk space they actually have available: the more disk space available, the larger we will set the cache to. See Bug 559942 for specifics.

We need to turn this feature off in the profile that Talos uses, so that we avoid the risk of the cache size varying across different Talos runs. 

Specifically, we need to set two new preferences introduced by the patch for Bug 559942 to false. Since we need to make this modification before landing the patch, I think the best approach is to add the following two lines to prefs.js of the Talos profile directory: 

user_pref("browser.cache.disk.smart_size.enabled", false);
user_pref("browser.cache.disk.smart_size.first_run", false);

Then, when we land the patch, Firefox will see that smart-sizing is disabled, and will default to using the standard cache size of 250MB. I tested that doing this exhibits the correct behavior. This should guarantee consistency, at least as far as the cache is concerned.

Comment 1

[Johnny Stenback (:jst)]

Bumping the priority on this one as this blocks a Firefox 4 beta6 blocker. What's a realistic time to get this done?

Comment 2

[alice nodelman [:alice] [:anode]]

Attachment: [checked in] force cache size for talos tests

Can you double check that the pref names are correct in the patch?

Comment 3

[Byron Milligan [:byronm]]

(In reply to comment #2)
> Created attachment 469490 [details] [diff] [review]
> force cache size for talos tests
> 
> Can you double check that the pref names are correct in the patch?

These are correct.

Comment 4

[alice nodelman [:alice] [:anode]]

Please comment in bug 591055 re: landing schedule.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 469490 [details] [diff] [review]
[checked in] force cache size for talos tests

Landed:
Checking in sample.config;
/cvsroot/mozilla/testing/performance/talos/sample.config,v  <--  sample.config
new revision: 1.50; previous revision: 1.49
done

Comment 6

[alice nodelman [:alice] [:anode]]

Done like dinner.