Closed
Bug 590826
Opened 14 years ago
Closed 14 years ago
SeaMonkey test failure in test_stricttransportsecurity.html due to use of uninitialized value
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Callek, Assigned: Callek)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure, Whiteboard: [sm-perma])
Attachments
(1 file, 1 obsolete file)
|
759 bytes,
patch
|
Details | Diff | Splinter Review |
In SeaMonkey we are failing test_stricttransportsecurity.html. Investigation showed we are returning early from mInPrivateBrowsingMode being "set". Where really its uninitialized because SeaMonkey does not have the private browsing service. This patch initializes it on class construction.
Attachment #469337 -
Flags: review?(sstamm)
|
||
Comment 1•14 years ago
|
||
How could we overlooked this? That's called 'collective blindness' :)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 469337 [details] [diff] [review] initialize it properly Wow, yeah. Probably five or six sets of eyes and we missed this. Looks like that default will work fine with the way the private browsing service is used in the rest of the file, so looks good.
Attachment #469337 -
Flags: review?(sstamm) → review+
|
Assignee | |
Comment 3•14 years ago
|
||
:rs (as sheriff) wants this to ridealong...
Attachment #469337 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/0acaab6b17c4
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•14 years ago
|
|
||
Updated•12 years ago
|
Keywords: intermittent-failure
|
|
||
Updated•12 years ago
|
Whiteboard: [sm-perma][orange] → [sm-perma]
You need to log in
before you can comment on or make changes to this bug.
Description
•