Closed Bug 590826 Opened 10 years ago Closed 10 years ago
Monkey test failure in test _stricttransportsecurity .html due to use of uninitialized value
In SeaMonkey we are failing test_stricttransportsecurity.html. Investigation showed we are returning early from mInPrivateBrowsingMode being "set". Where really its uninitialized because SeaMonkey does not have the private browsing service. This patch initializes it on class construction.
Attachment #469337 - Flags: review?(sstamm)
How could we overlooked this? That's called 'collective blindness' :)
Comment on attachment 469337 [details] [diff] [review] initialize it properly Wow, yeah. Probably five or six sets of eyes and we missed this. Looks like that default will work fine with the way the private browsing service is used in the rest of the file, so looks good.
Attachment #469337 - Flags: review?(sstamm) → review+
:rs (as sheriff) wants this to ridealong...
Attachment #469337 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [sm-perma][orange] → [sm-perma]
You need to log in before you can comment on or make changes to this bug.