Closed Bug 590826 Opened 10 years ago Closed 10 years ago

SeaMonkey test failure in test_stricttransportsecurity.html due to use of uninitialized value

Categories

(Core :: DOM: Core & HTML, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: Callek, Assigned: Callek)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [sm-perma])

Attachments

(1 file, 1 obsolete file)

Attached patch initialize it properly (obsolete) — Splinter Review
In SeaMonkey we are failing test_stricttransportsecurity.html.

Investigation showed we are returning early from mInPrivateBrowsingMode being "set".  Where really its uninitialized because SeaMonkey does not  have the private browsing service.

This patch initializes it on class construction.
Attachment #469337 - Flags: review?(sstamm)
How could we overlooked this?  That's called 'collective blindness' :)
Comment on attachment 469337 [details] [diff] [review]
initialize it properly

Wow, yeah.  Probably five or six sets of eyes and we missed this.  

Looks like that default will work fine with the way the private browsing service is used in the rest of the file, so looks good.
Attachment #469337 - Flags: review?(sstamm) → review+
:rs (as sheriff) wants this to ridealong...
Attachment #469337 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/0acaab6b17c4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Blocks: 438871
Blocks: SmTestFail
No longer blocks: 438871
Whiteboard: [sm-perma][orange] → [sm-perma]
You need to log in before you can comment on or make changes to this bug.