590848 - Freeze when closing about:fennec tab opened from prefs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Steps to reproduce (from Ioana Chiorean in bug 580197 comment 15):
1.Open Fennec
2.Slide the webpage to the left to reveal the control tab, press the gear icon
3.In preferences press About Fennec -> Go to Page
4.Slide the webpage to the right to reveal tabs and close last tab
(about:Fennec)

Results:  Fennec freezes with error "chrome://browser/content/browser.js, line 861: this._selectedTab.isLoading is not a function"

This is caused by #prefs-about-button passing a bad "owner" argument to BrowserUI.newTab.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 469373 [details] [diff] [review]
patch

And yeah we already bring up the tab to the front so we don't need that.
(if you could replace the ' by " when check-in :))

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

> (if you could replace the ' by " when check-in :))

nevermind

Comment 4

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/0b158275cb7e

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100826 Namoroka/4.0b5pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100826 Namoroka/4.0b5pre Fennec/2.0a1pre