590867 - It is difficult to display context menu "Exit Full Screen Mode" by right-clicking, if browser is "Tabs on Top"

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100825 Minefield/4.0b5pre ID:20100825062325
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100825 Minefield/4.0b5pre ID:20100825062325

It is difficult to display context menu "Exit Full Screen Mode" by right-clicking, if browser is "Tabs on Top".

if not "Tabs on Top", I move mouse pointer to the upper edge of the screen , then right-click, I can easily display context menu.

Reproducible: Always

Steps to Reproduce:
1. Start Minefield with new profile
2. Make sure "Tabs on Top" (default in Wndows)
3. Open some page
5. Go to full screen mode (F11)
4. Try to popup contex menu "Exit Full Screen Mode"

Actual Results:
 comparatively difficult

Expected Results:
 Context menu of screen edge should include "Exit Full Screen Mode" menuitem.
 Generally the context menu of tab amd tab strip.

Comment 1

[Alice0775 White]

I think this should be fixed.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Requesting feedback from UX.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

the same menu should ideally also be available in the title bar (area of the tab strip that does not contain tabs).

Comment 4

[Dietrich Ayala (:dietrich)]

Blocking- since it only applies to full screen mode, and is still possible, just a little harder. If you think this blocks, please explain why we can't ship as-is.

Comment 5

[Alan Thomas]

Attachment: add context menu to tab bar

Cheap and easy fix. Adds the two-item full screen context menu to the background of the tab bar.

alice suggested to append an "Exit Full Screen Mode" item to the tab context menus. This has low discoverability (the tab context menu is long enough), and users expect the Close Tab item to be last (on Windows at least).

Comment 6

[Dietrich Ayala (:dietrich)]

Comment on attachment 503449 [details] [diff] [review]
add context menu to tab bar

Getting UI review from Alex first.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 503449 [details] [diff] [review]
add context menu to tab bar

Looks good

Comment 8

[Dietrich Ayala (:dietrich)]

Comment on attachment 503449 [details] [diff] [review]
add context menu to tab bar

r=me with the comment updated to include the tabs toolbar.

Comment 9

[Alan Thomas]

Attachment: patch for checkin

Comment 10

[(no longer active)]

This requires approval before it can land.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 503724 [details] [diff] [review]
patch for checkin

a=beltzner, zero risk, please add the in-litmus flag when you check in.

Comment 12

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/86dff995b060

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b12pre) Gecko/20110222 Firefox/4.0b12pre

Why can't this be tested with a browser chrome test?