590877 - Replace current default page with about:home

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Marco Bonardo [:mak]]

bug 563723 added about:home, now we have to link it in the product so that it's used instead of the google hosted page.

Comment 1

[Marco Bonardo [:mak]]

I guess the magic happens in browserconfig.properties but maybe we want to change something in the process?
cc-ing gavin and mike

Comment 2

[:Gavin Sharp [email: [e-mail]]]

We can just change it in browserconfig.properties. Do we want to change it for all branding (nightly, "devpreview", official)?

Comment 3

[Marco Bonardo [:mak]]

nightly and unofficial are using other pages from what I see, not the search page

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Yeah, I know, but that doesn't mean we can't change them. Given that the branding and search URL replacing works correctly with about:home, I don't think there's any real reason to not switch them. But we can do that in a separate change at some later point, too.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Use about:home as the home page for nightlies, unofficial (alphas/devpreviews), and official branding (betas/releases).

(browser.startup.homepage_reset has been unused since forever - doesn't even have a default in firefox.js anymore)

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 472697 [details] [diff] [review]
patch

uir+ with the following caveat: we may need to special case zh-CN so that it still points to http://zh-cn.start3.mozilla.com/firefox/ but we can deal with that in a follow-up

Comment 7

[Justin Dolske [:Dolske]]

Comment on attachment 472697 [details] [diff] [review]
patch

Maybe give the metrics guys a heads up that this change is being made? Shouldn't matter, but just in case.

Comment 8

[Justin Dolske [:Dolske]]

Also, since this is that actual change that moves us away from a Google-hosted start page... I think it would be appropriate for someone (beltzner? shaver?) to formally approve this as being OK wrt to any known contractual obligations. Pretty sure this has already been discussed, but that's 87% assumption!

Comment 9

[Johnathan Nightingale [:johnath]]

(In reply to comment #8)
> Also, since this is that actual change that moves us away from a Google-hosted
> start page... I think it would be appropriate for someone (beltzner? shaver?)
> to formally approve this as being OK wrt to any known contractual obligations.
> Pretty sure this has already been discussed, but that's 87% assumption!

Yeah - we're good.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Attachment: for checkin

Comment 11

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/30577e999236

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Looks like this broke --enable-official-branding:

Preprocessor.Error: ('/home/dbaron/builds/mozilla-central/mozilla/other-licenses/branding/firefox/locales/jar.mn', 3, 'UNDEFINED_VAR', 'AB_CD')

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Bustage fix because I failed to test official branding:
https://hg.mozilla.org/mozilla-central/rev/c59be8574f7a

:(