Last Comment Bug 590877 - Replace current default page with about:home
: Replace current default page with about:home
Status: RESOLVED FIXED
[about-home]
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal with 1 vote (vote)
: Firefox 4.0b7
Assigned To: :Gavin Sharp [email: gavin@gavinsharp.com]
:
Mentors:
Depends on: 563723 649933
Blocks: 595356
  Show dependency treegraph
 
Reported: 2010-08-26 02:59 PDT by Marco Bonardo [::mak] (Away 6-20 Aug)
Modified: 2011-05-23 00:57 PDT (History)
12 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
beta7+


Attachments
patch (2.36 KB, patch)
2010-09-07 11:26 PDT, :Gavin Sharp [email: gavin@gavinsharp.com]
dolske: review+
mbeltzner: ui‑review+
Details | Diff | Splinter Review
for checkin (2.39 KB, patch)
2010-09-10 09:06 PDT, :Gavin Sharp [email: gavin@gavinsharp.com]
no flags Details | Diff | Splinter Review

Description Marco Bonardo [::mak] (Away 6-20 Aug) 2010-08-26 02:59:20 PDT
bug 563723 added about:home, now we have to link it in the product so that it's used instead of the google hosted page.
Comment 1 Marco Bonardo [::mak] (Away 6-20 Aug) 2010-08-26 03:04:02 PDT
I guess the magic happens in browserconfig.properties but maybe we want to change something in the process?
cc-ing gavin and mike
Comment 2 :Gavin Sharp [email: gavin@gavinsharp.com] 2010-08-26 12:44:11 PDT
We can just change it in browserconfig.properties. Do we want to change it for all branding (nightly, "devpreview", official)?
Comment 3 Marco Bonardo [::mak] (Away 6-20 Aug) 2010-08-26 14:59:00 PDT
nightly and unofficial are using other pages from what I see, not the search page
Comment 4 :Gavin Sharp [email: gavin@gavinsharp.com] 2010-08-27 09:26:39 PDT
Yeah, I know, but that doesn't mean we can't change them. Given that the branding and search URL replacing works correctly with about:home, I don't think there's any real reason to not switch them. But we can do that in a separate change at some later point, too.
Comment 5 :Gavin Sharp [email: gavin@gavinsharp.com] 2010-09-07 11:26:03 PDT
Created attachment 472697 [details] [diff] [review]
patch

Use about:home as the home page for nightlies, unofficial (alphas/devpreviews), and official branding (betas/releases).

(browser.startup.homepage_reset has been unused since forever - doesn't even have a default in firefox.js anymore)
Comment 6 Mike Beltzner [:beltzner, not reading bugmail] 2010-09-09 13:06:16 PDT
Comment on attachment 472697 [details] [diff] [review]
patch

uir+ with the following caveat: we may need to special case zh-CN so that it still points to http://zh-cn.start3.mozilla.com/firefox/ but we can deal with that in a follow-up
Comment 7 Justin Dolske [:Dolske] 2010-09-10 01:38:34 PDT
Comment on attachment 472697 [details] [diff] [review]
patch

Maybe give the metrics guys a heads up that this change is being made? Shouldn't matter, but just in case.
Comment 8 Justin Dolske [:Dolske] 2010-09-10 01:50:38 PDT
Also, since this is that actual change that moves us away from a Google-hosted start page... I think it would be appropriate for someone (beltzner? shaver?) to formally approve this as being OK wrt to any known contractual obligations. Pretty sure this has already been discussed, but that's 87% assumption!
Comment 9 Johnathan Nightingale [:johnath] 2010-09-10 05:35:07 PDT
(In reply to comment #8)
> Also, since this is that actual change that moves us away from a Google-hosted
> start page... I think it would be appropriate for someone (beltzner? shaver?)
> to formally approve this as being OK wrt to any known contractual obligations.
> Pretty sure this has already been discussed, but that's 87% assumption!

Yeah - we're good.
Comment 10 :Gavin Sharp [email: gavin@gavinsharp.com] 2010-09-10 09:06:24 PDT
Created attachment 474075 [details] [diff] [review]
for checkin
Comment 11 :Ehsan Akhgari (away Aug 1-5) 2010-09-10 09:36:43 PDT
http://hg.mozilla.org/mozilla-central/rev/30577e999236
Comment 12 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2010-09-10 13:26:19 PDT
Looks like this broke --enable-official-branding:

Preprocessor.Error: ('/home/dbaron/builds/mozilla-central/mozilla/other-licenses/branding/firefox/locales/jar.mn', 3, 'UNDEFINED_VAR', 'AB_CD')
Comment 13 :Gavin Sharp [email: gavin@gavinsharp.com] 2010-09-10 13:42:31 PDT
Bustage fix because I failed to test official branding:
https://hg.mozilla.org/mozilla-central/rev/c59be8574f7a

:(

Note You need to log in before you can comment on or make changes to this bug.