Replace current default page with about:home

RESOLVED FIXED in Firefox 4.0b7

Status

()

Firefox
General
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: mak, Assigned: Gavin)

Tracking

Trunk
Firefox 4.0b7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

(Whiteboard: [about-home])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
bug 563723 added about:home, now we have to link it in the product so that it's used instead of the google hosted page.
(Reporter)

Updated

7 years ago
blocking2.0: --- → ?
(Reporter)

Comment 1

7 years ago
I guess the magic happens in browserconfig.properties but maybe we want to change something in the process?
cc-ing gavin and mike
We can just change it in browserconfig.properties. Do we want to change it for all branding (nightly, "devpreview", official)?
(Reporter)

Comment 3

7 years ago
nightly and unofficial are using other pages from what I see, not the search page
Yeah, I know, but that doesn't mean we can't change them. Given that the branding and search URL replacing works correctly with about:home, I don't think there's any real reason to not switch them. But we can do that in a separate change at some later point, too.
blocking2.0: ? → beta6+
Created attachment 472697 [details] [diff] [review]
patch

Use about:home as the home page for nightlies, unofficial (alphas/devpreviews), and official branding (betas/releases).

(browser.startup.homepage_reset has been unused since forever - doesn't even have a default in firefox.js anymore)
Attachment #472697 - Flags: ui-review?(beltzner)
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Whiteboard: [has patch][needs ui-r beltzner]
Comment on attachment 472697 [details] [diff] [review]
patch

uir+ with the following caveat: we may need to special case zh-CN so that it still points to http://zh-cn.start3.mozilla.com/firefox/ but we can deal with that in a follow-up
Attachment #472697 - Flags: ui-review?(beltzner) → ui-review+
Attachment #472697 - Flags: review?(dolske)
Whiteboard: [has patch][needs ui-r beltzner] → [has patch]
Comment on attachment 472697 [details] [diff] [review]
patch

Maybe give the metrics guys a heads up that this change is being made? Shouldn't matter, but just in case.
Attachment #472697 - Flags: review?(dolske) → review+
Also, since this is that actual change that moves us away from a Google-hosted start page... I think it would be appropriate for someone (beltzner? shaver?) to formally approve this as being OK wrt to any known contractual obligations. Pretty sure this has already been discussed, but that's 87% assumption!
(In reply to comment #8)
> Also, since this is that actual change that moves us away from a Google-hosted
> start page... I think it would be appropriate for someone (beltzner? shaver?)
> to formally approve this as being OK wrt to any known contractual obligations.
> Pretty sure this has already been discussed, but that's 87% assumption!

Yeah - we're good.
Keywords: checkin-needed
Created attachment 474075 [details] [diff] [review]
for checkin
Attachment #472697 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/30577e999236
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch]
Target Milestone: --- → Firefox 4.0b6
Looks like this broke --enable-official-branding:

Preprocessor.Error: ('/home/dbaron/builds/mozilla-central/mozilla/other-licenses/branding/firefox/locales/jar.mn', 3, 'UNDEFINED_VAR', 'AB_CD')
Bustage fix because I failed to test official branding:
https://hg.mozilla.org/mozilla-central/rev/c59be8574f7a

:(
Blocks: 595356
(Reporter)

Updated

6 years ago
Whiteboard: [about-home]
Depends on: 649933
You need to log in before you can comment on or make changes to this bug.