Last Comment Bug 590932 - [SeaMonkey] Replace "emptytext" in abCardOverlay with "placeholder"
: [SeaMonkey] Replace "emptytext" in abCardOverlay with "placeholder"
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: UI Design (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b1
Assigned To: Nomis101
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-26 08:14 PDT by Nomis101
Modified: 2010-09-19 09:29 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Fix (4.05 KB, patch)
2010-08-26 08:14 PDT, Nomis101
neil: review+
Details | Diff | Splinter Review
Fix v2 (5.23 KB, patch)
2010-08-27 05:52 PDT, Nomis101
neil: review+
Details | Diff | Splinter Review

Description Nomis101 2010-08-26 08:14:49 PDT
Created attachment 469465 [details] [diff] [review]
Fix

This patch will replace "emptytext" in abCardOverlay with "placeholder". It is a follow-up to Bug 550186 and Bug 551747.
Comment 1 neil@parkwaycc.co.uk 2010-08-26 14:20:17 PDT
Comment on attachment 469465 [details] [diff] [review]
Fix

Note that you seem to have overlooked the reference in abCardOverlay.js (both in SeaMonkey and in Thunderbird).
Comment 2 Nomis101 2010-08-26 14:54:59 PDT
(In reply to comment #1)
> Note that you seem to have overlooked the reference in abCardOverlay.js (both
> in SeaMonkey and in Thunderbird).

Oops, you are right. Should I make a new patch with abCardOverlay.js included? Or a follow-up patch?
Comment 3 Philip Chee 2010-08-27 05:34:06 PDT
New patch please.
Comment 4 Nomis101 2010-08-27 05:52:21 PDT
Created attachment 469849 [details] [diff] [review]
Fix v2

Patch with abCardOverlay.js
Comment 5 Nomis101 2010-09-03 06:57:12 PDT
I don't have the adequate rights to check this in. So if anyone can do this, that would be nice.
Comment 6 Justin Wood (:Callek) 2010-09-09 20:55:24 PDT
(In reply to comment #5)
> I don't have the adequate rights to check this in. So if anyone can do this,
> that would be nice.

Done http://hg.mozilla.org/comm-central/rev/2bcd6ba4d38e

But in the future, please use/read: 
http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed

Note You need to log in before you can comment on or make changes to this bug.