Closed
Bug 590932
Opened 16 years ago
Closed 16 years ago
[SeaMonkey] Replace "emptytext" in abCardOverlay with "placeholder"
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b1
People
(Reporter: Nomis101, Assigned: Nomis101)
Details
Attachments
(1 file, 1 obsolete file)
|
5.23 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
This patch will replace "emptytext" in abCardOverlay with "placeholder". It is a follow-up to Bug 550186 and Bug 551747.
Attachment #469465 -
Flags: review?(neil)
|
||
Updated•16 years ago
|
Assignee: nobody → Nomis101
Status: NEW → ASSIGNED
|
||
Comment 1•16 years ago
|
||
Comment on attachment 469465 [details] [diff] [review]
Fix
Note that you seem to have overlooked the reference in abCardOverlay.js (both in SeaMonkey and in Thunderbird).
Attachment #469465 -
Flags: review?(neil) → review+
(In reply to comment #1)
> Note that you seem to have overlooked the reference in abCardOverlay.js (both
> in SeaMonkey and in Thunderbird).
Oops, you are right. Should I make a new patch with abCardOverlay.js included? Or a follow-up patch?
|
||
Comment 3•16 years ago
|
||
New patch please.
Patch with abCardOverlay.js
Attachment #469465 -
Attachment is obsolete: true
Attachment #469849 -
Flags: review?(neil)
|
|
||
Updated•16 years ago
|
Attachment #469849 -
Flags: review?(neil) → review+
Keywords: checkin-needed
I don't have the adequate rights to check this in. So if anyone can do this, that would be nice.
|
||
Comment 6•16 years ago
|
||
(In reply to comment #5)
> I don't have the adequate rights to check this in. So if anyone can do this,
> that would be nice.
Done http://hg.mozilla.org/comm-central/rev/2bcd6ba4d38e
But in the future, please use/read:
http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed
|
||
Updated•16 years ago
|
Target Milestone: --- → seamonkey2.1b1
You need to log in
before you can comment on or make changes to this bug.
Description
•