Closed
Bug 590960
Opened 14 years ago
Closed 14 years ago
nuke PerformanceComparator in favor os compare-talos
Categories
(Tree Management Graveyard :: TBPL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Swatinem, Assigned: Swatinem)
Details
Attachments
(1 file, 1 obsolete file)
|
10.49 KB,
patch
|
mstange
:
review+
sdwilsh
:
feedback+
|
Details | Diff | Splinter Review |
mconnor/sdwilsh: Running the comparator without passing it all the tests would be nice. I asked about this in irc: what about moving it to tbpl completely? (Or at least to the tbpl repo with the ability to run it separately still)
Attachment #469508 -
Flags: review?(mstange)
Attachment #469508 -
Flags: feedback?(sdwilsh)
|
Assignee | |
Comment 1•14 years ago
|
||
really focuses the popup now, also adds the ability to pass multiple revs to compare-talos, just that there is no difference in how the result is displayed.
Attachment #469508 -
Attachment is obsolete: true
Attachment #469531 -
Flags: review?(mstange)
Attachment #469531 -
Flags: feedback?(sdwilsh)
Attachment #469508 -
Flags: review?(mstange)
Attachment #469508 -
Flags: feedback?(sdwilsh)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 469531 [details] [diff] [review] patch You could also open this in a floating iframe on the page if you don't want to do a popup.
Attachment #469531 -
Flags: feedback?(sdwilsh) → feedback+
|
||
Comment 3•14 years ago
|
||
Comment on attachment 469531 [details] [diff] [review] patch yay code simplification!
Attachment #469531 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/c1729b6543db
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•9 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•