591014 - Crash [@ imgRequestProxy::GetStaticRequest ] when print-previewing a Crate & Barrel receipt

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: fix

STR (the steps I took when this happened to me):
 1. Purchase a gift from a wedding registry at http://www.crateandbarrel.com
 2. When done, try to print-preview the receipt.
   --> CRASH  [@ imgRequestProxy::GetStaticRequest ]

I wasn't able to reproduce this in a locally saved copy of the page (even after fixing the relative url()'s in the saved stylesheets to be absolute URLs), but I did trap the crashing page in my session-restore-cache, so I was able to test it a bit by restoring the session & retrying print-preview.

Crash reports:
bp-26a6e97a-f90d-477d-9a37-744862100826
bp-235e67ca-8885-4d4c-8411-172c42100826

Regression from bug 587902, by code inspection.  Fix attached.

Comment 1

[Daniel Holbert [:dholbert]]

This should block Firefox 4 beta 5, since this is a regression from a patch that landed for beta 5 (so if left unfixed, it'll be a new crash introduced in beta 5).

Note that this is a crash on a null deref, so it's not particularly scary -- just annoying.

Comment 2

[Daniel Holbert [:dholbert]]

looks like there have been a few other reports of this crash in the last day or two, including one by juanb (according to the crash's comment field), bp-7fb171f0-a3f8-4059-8b59-d1b012100825

cc'ing juanb in case he's interested

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix w/ 2 tweaks (r=joe)

Here's the fix again, with two tweaks:
 - Add parens after the "||" in the modified line, for clarity.
 - Fix up the null-check for aImage in imgRequestProxy::SetImage (joe pointed this out to me in IRC).  (The same fix -- but in a different file -- that joe brought up in bug 587902 comment 16.)

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: fix w/ 2 tweaks, ready for landing (r=joe)

...and here's the fix once more, as an |hg export| for convenience, so some kind soul can hopefully land this as a ridealong in one of the next few pushes. :)

Comment 6

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/313d5b53c01b