Closed Bug 591046 Opened 14 years ago Closed 14 years ago

Unparenthesized macro breaks static checking builds

Categories

(Core :: Networking: HTTP, defect)

Product:
Core
Component:
Networking: HTTP
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ehren.m, Assigned: ehren.m)

References

Details

Attachments

(1 file)

patch
1.82 KB, patch
dwitte
: review+
Details | Diff | Splinter Review 
http://hg.mozilla.org/mozilla-central/rev/72d2863f43c7 has two instances of 
if NS_FAILED(rv)  // no parentheses

In static checking builds NS_FAILED is an inline function: http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsError.h#116
Attached patch patch — — Splinter Review 

        Attachment #469608 -
        Flags: review?(dwitte)

    
    

    
  
Comment on attachment 469608 [details] [diff] [review]
patch

r=dwitte

        Attachment #469608 -
        Flags: review?(dwitte) → review+

    
  
Keywords: checkin-needed

    
  
Assignee: nobody → ehren.m

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/4aa15010c205
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: