Closed
Bug 591046
Opened 15 years ago
Closed 15 years ago
Unparenthesized macro breaks static checking builds
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ehren.m, Assigned: ehren.m)
References
Details
Attachments
(1 file)
|
1.82 KB,
patch
|
dwitte
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/rev/72d2863f43c7 has two instances of
if NS_FAILED(rv) // no parentheses
In static checking builds NS_FAILED is an inline function: http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsError.h#116
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #469608 -
Flags: review?(dwitte)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 469608 [details] [diff] [review]
patch
r=dwitte
Attachment #469608 -
Flags: review?(dwitte) → review+
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → ehren.m
|
|
||
Comment 3•15 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•