Status

()

defect
RESOLVED FIXED
9 years ago
4 years ago

People

(Reporter: bholley, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 21 obsolete attachments)

3.62 KB, patch
Details | Diff | Splinter Review
816 bytes, patch
Details | Diff | Splinter Review
265 bytes, patch
Details | Diff | Splinter Review
(Reporter)

Description

9 years ago
I've changed the QA contact - if anybody gets bugmail from this, please let me know and I'll figure out how to stop spamming you.
(Reporter)

Comment 1

9 years ago
Posted patch test patch (obsolete) — Splinter Review
Trying it out

Review: bobbyholley+bmo@gmail.com
(Reporter)

Updated

9 years ago
Attachment #469697 - Flags: review?(bobbyholley+bmo)
(Reporter)

Updated

9 years ago
Attachment #469697 - Flags: review?(bobbyholley+bmo)
(Reporter)

Comment 2

9 years ago
Posted patch try 2 (obsolete) — Splinter Review
trying again.
(Reporter)

Comment 3

9 years ago
Posted patch try 3 (obsolete) — Splinter Review
Third time's the charm
Attachment #469700 - Flags: review?(bobbyholley+bmo)
(Reporter)

Comment 4

9 years ago
Posted patch colon test (obsolete) — Splinter Review
This is to see if I can flag for :bholley
Attachment #469703 - Flags: review?(bobbyholley+bmo)
(Reporter)

Comment 5

9 years ago
Posted patch final test (obsolete) — Splinter Review
This test involves selecting multiple reviewers, selecting a super-reviewer, and mixing colon notation with regular bugmails.

If you get flagged for review by this, it means I can flag for review when pushing to bugzilla! Oh happy day.
Attachment #469704 - Flags: superreview?(dholbert)
Attachment #469704 - Flags: review?(joe)
Attachment #469704 - Flags: review?(dholbert)
r+sr=dholbert!!
(Reporter)

Updated

9 years ago
Attachment #469700 - Flags: review?(bobbyholley+bmo)
(Reporter)

Updated

9 years ago
Attachment #469703 - Flags: review?(bobbyholley+bmo)
(Reporter)

Updated

9 years ago
Attachment #469704 - Flags: superreview?(dholbert)
Attachment #469704 - Flags: review?(joe)
Attachment #469704 - Flags: review?(dholbert)
I'll get bugmail for it every night that it's open, since I have a query for bugs that don't have the right QA contact, but I eat bugspam for breakfast.
(Reporter)

Comment 8

9 years ago
(In reply to comment #7)
> I'll get bugmail for it every night that it's open, since I have a query for
> bugs that don't have the right QA contact, but I eat bugspam for breakfast.

I'll just close it for now then, and reopen it when I need it again.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Comment 10

9 years ago
Posted patch patch v2 (obsolete) — Splinter Review
Attachment #469697 - Attachment is obsolete: true
Attachment #469698 - Attachment is obsolete: true
Attachment #469700 - Attachment is obsolete: true
Attachment #469703 - Attachment is obsolete: true
Attachment #469704 - Attachment is obsolete: true
Attachment #470915 - Attachment is obsolete: true
(Reporter)

Comment 11

9 years ago
Posted patch patch v2 (obsolete) — Splinter Review
https://bugzilla.mozilla.org/show_bug.cgi?id=591560
Attachment #470916 - Attachment is obsolete: true
(Reporter)

Comment 12

9 years ago
Posted patch patch v2 (obsolete) — Splinter Review
https://bugzilla.mozilla.org/show_bug.cgi?id=591560
Attachment #470927 - Attachment is obsolete: true
(Reporter)

Comment 13

9 years ago
Posted patch patch v2 (obsolete) — Splinter Review
https://bugzilla.mozilla.org/show_bug.cgi?id=591560
Attachment #470930 - Attachment is obsolete: true
(Reporter)

Comment 14

8 years ago
Looks like git-bz was broken by FF4, so I've got some more testing to do.

Buckle up philor. ;-)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 15

8 years ago
Posted patch Bug 653930 - Tests. v1 (obsolete) — Splinter Review
Attachment #530530 - Flags: review?(bobbyholley+bmo)
(Reporter)

Comment 16

8 years ago
Posted patch Bug 653930 - v1 (obsolete) — Splinter Review
Attachment #530531 - Flags: review?(bobbyholley+bmo)
(Reporter)

Comment 17

8 years ago
Comment on attachment 530531 [details] [diff] [review]
Bug 653930 - v1

Review of attachment 530531 [details] [diff] [review]:

overall comments.

more overall comments.

::: content/base/src/nsFrameLoader.cpp
@@ +865,5 @@
+void
+nsFrameLoader::MarginsChanged(PRUint32 aMarginWidth,
+                              PRUint32 aMarginHeight)
+{
+  // We assume that the margins are always zero for remote frames.

test comment

@@ +875,5 @@
+  // margins.
+  if (!mDocShell)
+    return;
+
+  // Set the margins

another test comment

::: content/base/src/nsFrameLoader.h
@@ +209,5 @@
 
   /**
+   * Called when the margin properties of the containing frame are changed.
+   */
+  void MarginsChanged(PRUint32 aMarginWidth, PRUint32 aMarginHeight);

last test comment
Attachment #530531 - Flags: review?(bobbyholley+bmo) → review-
(Reporter)

Updated

8 years ago
Attachment #530530 - Flags: review?(bobbyholley+bmo)
(Reporter)

Comment 18

8 years ago
All is well. Re-closing.
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago8 years ago
Resolution: --- → FIXED
Version: unspecified → Trunk
(Reporter)

Comment 19

8 years ago
good evening :-)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I actually switched that whine mail to monthly, and then stopped paying any attention to it, so if you want to just leave it open that's fine by me.
(Reporter)

Comment 21

8 years ago
Posted patch Some nonsense from benoit. (obsolete) — Splinter Review
Attachment #470931 - Attachment is obsolete: true
(Reporter)

Comment 22

8 years ago
(In reply to Phil Ringnalda (:philor) from comment #20)
> I actually switched that whine mail to monthly, and then stopped paying any
> attention to it, so if you want to just leave it open that's fine by me.

but the metrics! ;-)
(Reporter)

Comment 23

8 years ago
Posted patch More benoit nonsense. (obsolete) — Splinter Review
Attachment #577859 - Attachment is obsolete: true
(Reporter)

Comment 24

8 years ago
Posted patch Makoto magic! (obsolete) — Splinter Review
Attachment #577863 - Attachment is obsolete: true
(Reporter)

Comment 25

8 years ago
Posted patch First banner patch. (obsolete) — Splinter Review
Attachment #577864 - Attachment is obsolete: true
(Reporter)

Comment 26

8 years ago
Posted patch Banner patch 0. (obsolete) — Splinter Review
Attachment #578692 - Attachment is obsolete: true
(Reporter)

Comment 27

8 years ago
Posted patch Banner patch 1. (obsolete) — Splinter Review
(Reporter)

Comment 28

8 years ago
Until next time!
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 29

6 years ago
The main idea behind this thing seems to be that we don't want script to quickly
close the window before the user has time to read the notification. Given the
fuzziness of the constraint here, I think we can (and maybe even should) unblock
a little bit later in the event loop, rather than immediately after the script
terminates.
(Reporter)

Comment 30

6 years ago
The main idea behind this thing seems to be that we don't want script to quickly
close the window before the user has time to read the notification. Given the
fuzziness of the constraint here, I think we can (and maybe even should) unblock
a little bit later in the event loop, rather than immediately after the script
terminates.
Attachment #530530 - Attachment is obsolete: true
Attachment #530531 - Attachment is obsolete: true
Attachment #578695 - Attachment is obsolete: true
Attachment #578696 - Attachment is obsolete: true
Attachment #742575 - Attachment is obsolete: true
Attachment #742580 - Attachment is obsolete: true
Attachment #742580 - Attachment is obsolete: false
Attachment #742580 - Attachment is obsolete: true
Attachment #742580 - Attachment is obsolete: false
Resolution: FIXED → INVALID
Attachment #578695 - Attachment is obsolete: false
Attachment #742580 - Attachment is obsolete: true
Attachment #578695 - Attachment is obsolete: true
comment
Resolution: INVALID → FIXED
Attachment #578695 - Attachment is obsolete: false
Attachment #742580 - Attachment is obsolete: false
Comment on attachment 578695 [details] [diff] [review]
Banner patch 0.

comment
Attachment #578695 - Attachment is obsolete: true
Attachment #742580 - Attachment is obsolete: true
Comment on attachment 742580 [details] [diff] [review]
Replace the scripted closing unblocker termination function with an runnable. v1

comment
Attachment #742575 - Attachment is obsolete: false
Attachment #742580 - Attachment is obsolete: false
Comment on attachment 742575 [details] [diff] [review]
Replace the scripted closing unblocker termination function with an runnable. v1

test
Attachment #742575 - Attachment is obsolete: true
Posted patch Element. (obsolete) — Splinter Review
comment
Attachment #8663945 - Flags: ui-review?(continuation)
Attachment #8663945 - Flags: superreview+
Attachment #8663945 - Flags: review?(continuation)
Attachment #8663945 - Flags: feedback?(continuation)
Attachment #8663945 - Flags: feedback+
Posted patch Element. (obsolete) — Splinter Review
Attachment #8663945 - Attachment is obsolete: true
Attachment #8663945 - Flags: ui-review?(continuation)
Attachment #8663945 - Flags: review?(continuation)
Attachment #8663945 - Flags: feedback?(continuation)
Attachment #8663946 - Attachment is obsolete: true
Component: ImageLib → General
You need to log in before you can comment on or make changes to this bug.