bholley testing bug for git-bz

RESOLVED FIXED

Status

()

Core
General
RESOLVED FIXED
7 years ago
2 years ago

People

(Reporter: bholley, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 21 obsolete attachments)

3.62 KB, patch
Details | Diff | Splinter Review
816 bytes, patch
Details | Diff | Splinter Review
265 bytes, patch
Details | Diff | Splinter Review
I've changed the QA contact - if anybody gets bugmail from this, please let me know and I'll figure out how to stop spamming you.
Created attachment 469697 [details] [diff] [review]
test patch

Trying it out

Review: bobbyholley+bmo@gmail.com
Attachment #469697 - Flags: review?(bobbyholley+bmo)
Attachment #469697 - Flags: review?(bobbyholley+bmo)
Created attachment 469698 [details] [diff] [review]
try 2

trying again.
Created attachment 469700 [details] [diff] [review]
try 3

Third time's the charm
Attachment #469700 - Flags: review?(bobbyholley+bmo)
Created attachment 469703 [details] [diff] [review]
colon test

This is to see if I can flag for :bholley
Attachment #469703 - Flags: review?(bobbyholley+bmo)
Created attachment 469704 [details] [diff] [review]
final test

This test involves selecting multiple reviewers, selecting a super-reviewer, and mixing colon notation with regular bugmails.

If you get flagged for review by this, it means I can flag for review when pushing to bugzilla! Oh happy day.
Attachment #469704 - Flags: superreview?(dholbert)
Attachment #469704 - Flags: review?(joe)
Attachment #469704 - Flags: review?(dholbert)
r+sr=dholbert!!
Attachment #469700 - Flags: review?(bobbyholley+bmo)
Attachment #469703 - Flags: review?(bobbyholley+bmo)
Attachment #469704 - Flags: superreview?(dholbert)
Attachment #469704 - Flags: review?(joe)
Attachment #469704 - Flags: review?(dholbert)
I'll get bugmail for it every night that it's open, since I have a query for bugs that don't have the right QA contact, but I eat bugspam for breakfast.
(In reply to comment #7)
> I'll get bugmail for it every night that it's open, since I have a query for
> bugs that don't have the right QA contact, but I eat bugspam for breakfast.

I'll just close it for now then, and reopen it when I need it again.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Created attachment 470915 [details] [diff] [review]
patch v2

https://bugzilla.mozilla.org/show_bug.cgi?id=591560
Created attachment 470916 [details] [diff] [review]
patch v2
Attachment #469697 - Attachment is obsolete: true
Attachment #469698 - Attachment is obsolete: true
Attachment #469700 - Attachment is obsolete: true
Attachment #469703 - Attachment is obsolete: true
Attachment #469704 - Attachment is obsolete: true
Attachment #470915 - Attachment is obsolete: true
Created attachment 470927 [details] [diff] [review]
patch v2

https://bugzilla.mozilla.org/show_bug.cgi?id=591560
Attachment #470916 - Attachment is obsolete: true
Created attachment 470930 [details] [diff] [review]
patch v2

https://bugzilla.mozilla.org/show_bug.cgi?id=591560
Attachment #470927 - Attachment is obsolete: true
Created attachment 470931 [details] [diff] [review]
patch v2

https://bugzilla.mozilla.org/show_bug.cgi?id=591560
Attachment #470930 - Attachment is obsolete: true
Looks like git-bz was broken by FF4, so I've got some more testing to do.

Buckle up philor. ;-)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 530530 [details] [diff] [review]
Bug 653930 - Tests. v1
Attachment #530530 - Flags: review?(bobbyholley+bmo)
Created attachment 530531 [details] [diff] [review]
Bug 653930 - v1
Attachment #530531 - Flags: review?(bobbyholley+bmo)
Comment on attachment 530531 [details] [diff] [review]
Bug 653930 - v1

Review of attachment 530531 [details] [diff] [review]:

overall comments.

more overall comments.

::: content/base/src/nsFrameLoader.cpp
@@ +865,5 @@
+void
+nsFrameLoader::MarginsChanged(PRUint32 aMarginWidth,
+                              PRUint32 aMarginHeight)
+{
+  // We assume that the margins are always zero for remote frames.

test comment

@@ +875,5 @@
+  // margins.
+  if (!mDocShell)
+    return;
+
+  // Set the margins

another test comment

::: content/base/src/nsFrameLoader.h
@@ +209,5 @@
 
   /**
+   * Called when the margin properties of the containing frame are changed.
+   */
+  void MarginsChanged(PRUint32 aMarginWidth, PRUint32 aMarginHeight);

last test comment
Attachment #530531 - Flags: review?(bobbyholley+bmo) → review-
Attachment #530530 - Flags: review?(bobbyholley+bmo)
All is well. Re-closing.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago6 years ago
Resolution: --- → FIXED
Version: unspecified → Trunk
good evening :-)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I actually switched that whine mail to monthly, and then stopped paying any attention to it, so if you want to just leave it open that's fine by me.
Created attachment 577859 [details] [diff] [review]
Some nonsense from benoit.
Attachment #470931 - Attachment is obsolete: true
(In reply to Phil Ringnalda (:philor) from comment #20)
> I actually switched that whine mail to monthly, and then stopped paying any
> attention to it, so if you want to just leave it open that's fine by me.

but the metrics! ;-)
Created attachment 577863 [details] [diff] [review]
More benoit nonsense.
Attachment #577859 - Attachment is obsolete: true
Created attachment 577864 [details] [diff] [review]
Makoto magic!
Attachment #577863 - Attachment is obsolete: true
Created attachment 578692 [details] [diff] [review]
First banner patch.
Attachment #577864 - Attachment is obsolete: true
Created attachment 578695 [details] [diff] [review]
Banner patch 0.
Attachment #578692 - Attachment is obsolete: true
Created attachment 578696 [details] [diff] [review]
Banner patch 1.
Until next time!
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Created attachment 742575 [details] [diff] [review]
Replace the scripted closing unblocker termination function with an runnable. v1

The main idea behind this thing seems to be that we don't want script to quickly
close the window before the user has time to read the notification. Given the
fuzziness of the constraint here, I think we can (and maybe even should) unblock
a little bit later in the event loop, rather than immediately after the script
terminates.
Created attachment 742580 [details] [diff] [review]
Replace the scripted closing unblocker termination function with an runnable. v1

The main idea behind this thing seems to be that we don't want script to quickly
close the window before the user has time to read the notification. Given the
fuzziness of the constraint here, I think we can (and maybe even should) unblock
a little bit later in the event loop, rather than immediately after the script
terminates.
Attachment #530530 - Attachment is obsolete: true
Attachment #530531 - Attachment is obsolete: true
Attachment #578695 - Attachment is obsolete: true
Attachment #578696 - Attachment is obsolete: true
Attachment #742575 - Attachment is obsolete: true
Attachment #742580 - Attachment is obsolete: true
Attachment #742580 - Attachment is obsolete: false
Attachment #742580 - Attachment is obsolete: true
Attachment #742580 - Attachment is obsolete: false
Resolution: FIXED → INVALID
Attachment #578695 - Attachment is obsolete: false
Attachment #742580 - Attachment is obsolete: true
Attachment #578695 - Attachment is obsolete: true
comment
Resolution: INVALID → FIXED
Attachment #578695 - Attachment is obsolete: false
Attachment #742580 - Attachment is obsolete: false
Comment on attachment 578695 [details] [diff] [review]
Banner patch 0.

comment
Attachment #578695 - Attachment is obsolete: true
Attachment #742580 - Attachment is obsolete: true
Comment on attachment 742580 [details] [diff] [review]
Replace the scripted closing unblocker termination function with an runnable. v1

comment
Attachment #742575 - Attachment is obsolete: false
Attachment #742580 - Attachment is obsolete: false
Comment on attachment 742575 [details] [diff] [review]
Replace the scripted closing unblocker termination function with an runnable. v1

test
Attachment #742575 - Attachment is obsolete: true
Created attachment 8663945 [details] [diff] [review]
Element.

comment
Attachment #8663945 - Flags: ui-review?(continuation)
Attachment #8663945 - Flags: superreview+
Attachment #8663945 - Flags: review?(continuation)
Attachment #8663945 - Flags: feedback?(continuation)
Attachment #8663945 - Flags: feedback+
Created attachment 8663946 [details] [diff] [review]
Element.
Attachment #8663945 - Attachment is obsolete: true
Attachment #8663945 - Flags: ui-review?(continuation)
Attachment #8663945 - Flags: review?(continuation)
Attachment #8663945 - Flags: feedback?(continuation)
Created attachment 8664388 [details] [diff] [review]
Element.
Attachment #8663946 - Attachment is obsolete: true
Component: ImageLib → General
Created attachment 8672144 [details] [diff] [review]
Example file move with git.
You need to log in before you can comment on or make changes to this bug.