Typos in safebrowsing code

RESOLVED FIXED

Status

--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: alqahira, Assigned: alqahira)

Tracking

Details

Attachments

(1 attachment)

Created attachment 469694 [details] [diff] [review]
Fix

In working on the certerror AboutModule, I found two typos in the safebrowsing code on which I based my stuff:

1) the CID for the SafeBrowsingAboutModule is missing one of its bits (the leading 8 in the second hunk): http://hg.mozilla.org/camino/annotate/f70bb96c693f/src/safebrowsing/SafeBrowsingAboutModule.h#l65

2) an incorrect entity/DTD declaration in blockedSite.xhtml (I suspect we made a careless deletion when we were deleting unneeded entity/DTD declarations in that file and left the wrong shorthand): http://hg.mozilla.org/camino/annotate/f70bb96c693f/resources/application/blockedSite.xhtml#l5

Neither of these appear to cause any problems (and the CID isn't stored anywhere), but in the interest of code cleanliness, future-proofing (say, if XPCOM starts actually demanding its CIDs be 128 bits as specified :P ), and to protect future copiers like me, we ought to fix them.
Attachment #469694 - Flags: superreview?(stuart.morgan+bugzilla)

Comment 1

8 years ago
Comment on attachment 469694 [details] [diff] [review]
Fix

sr=smorgan
Attachment #469694 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
http://hg.mozilla.org/camino/rev/e47c23b2297c
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.