591110 - Typos in safebrowsing code

Status: RESOLVED FIXED

(Camino Graveyard :: Security, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fix

In working on the certerror AboutModule, I found two typos in the safebrowsing code on which I based my stuff:

1) the CID for the SafeBrowsingAboutModule is missing one of its bits (the leading 8 in the second hunk): http://hg.mozilla.org/camino/annotate/f70bb96c693f/src/safebrowsing/SafeBrowsingAboutModule.h#l65

2) an incorrect entity/DTD declaration in blockedSite.xhtml (I suspect we made a careless deletion when we were deleting unneeded entity/DTD declarations in that file and left the wrong shorthand): http://hg.mozilla.org/camino/annotate/f70bb96c693f/resources/application/blockedSite.xhtml#l5

Neither of these appear to cause any problems (and the CID isn't stored anywhere), but in the interest of code cleanliness, future-proofing (say, if XPCOM starts actually demanding its CIDs be 128 bits as specified :P ), and to protect future copiers like me, we ought to fix them.

Comment 1

[Stuart Morgan]

Comment on attachment 469694 [details] [diff] [review]
Fix

sr=smorgan

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/e47c23b2297c