Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Disable hardware acceleration in safe mode

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Joe Drew (not getting mail), Assigned: Joe Drew (not getting mail))

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(blocking2.0 beta5+)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 469740 [details] [diff] [review]
Disable hw accel in safe mode

We need to disable all hardware acceleration when we are in safe mode.
Attachment #469740 - Flags: review?(bas.schouten)
(Assignee)

Updated

7 years ago
Assignee: nobody → joe
(Assignee)

Updated

7 years ago
blocking2.0: --- → beta5+
Comment on attachment 469740 [details] [diff] [review]
Disable hw accel in safe mode

We should followup with putting all the enable acceleration or not logic in a single function on nsBaseWidget, but for now this is fine.
Attachment #469740 - Flags: review?(bas.schouten) → review+
(Assignee)

Comment 2

7 years ago
http://hg.mozilla.org/mozilla-central/rev/52546421427a
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 3

7 years ago
Comment on attachment 469740 [details] [diff] [review]
Disable hw accel in safe mode

>#ifdef CAIRO_HAS_D2D_SURFACE
>    NS_RegisterMemoryReporter(new D2DCacheReporter());
>     NS_RegisterMemoryReporter(new D2DVRAMReporter());
>     mD2DDevice = NULL;
> 
>     PRBool d2dDisabled = PR_FALSE;
>     nsresult rv = pref->GetBoolPref("gfx.direct2d.disabled", &d2dDisabled);
>     if (NS_FAILED(rv))
>         d2dDisabled = PR_FALSE;
> 
>-    if (isVistaOrHigher && !d2dDisabled) {
>+    nsCOMPtr<nsIXULRuntime> xr = do_GetService("@mozilla.org/xre/runtime;1");
>+    PRBool safeMode = PR_FALSE;
>+    if (xr)
>+      xr->GetInSafeMode(&safeMode);
...
> #endif
> 
>     PRInt32 rmode;
>-    if (NS_SUCCEEDED(pref->GetIntPref("mozilla.widget.render-mode", &rmode))) {
>+    if (!safeMode &&
>+	NS_SUCCEEDED(pref->GetIntPref("mozilla.widget.render-mode", &rmode))) {
Sadly safeMode is only defined if CAIRO_HAS_D2D_SURFACE is ...
Created attachment 470235 [details] [diff] [review]
Fix bustage when CAIRO_HAS_D2D_SURFACE is not defined

in the likely chance this is not reviewed in the next hour, I'll appreciate someone landing for me during the day on Sunday, I provided a pre-emptive checkin comment for that task.
Attachment #470235 - Flags: review?

Updated

7 years ago
Attachment #470235 - Flags: review? → review?(bas.schouten)
Attachment #470235 - Flags: review?(bas.schouten) → review+
Created attachment 470250 [details] [diff] [review]
rebased
Attachment #470235 - Attachment is obsolete: true
Attachment #470250 - Flags: review+
You need to log in before you can comment on or make changes to this bug.