591163 - mochitest for bug 413777

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

tabbing through a:focus { overflow: scroll; } shouldn't result in accessible recreation for HTML a.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 469814 [details] [diff] [review]
patch

>-    for (var idx = 0; idx < this.mEventSeq.length; idx++) {
>+    var idx = 0;
>+    for (; idx < this.mEventSeq.length; idx++) {

Personally, I would never have written it this way, I would always put the initialization in the for loop expression. So:

var idx;
for (idx = 0; ...

But I'll leave it to you to write it as you see fit. To me it looks strange. :)

>+    // No any expected event was registered, proceed next invoker to ensure
>+    // unexpected events for current invoker won't be handled.

This must be rephrased to be clear:

+    // No expected events were registered, proceed to next invoker to ensure
+    // unexpected events for current invoker won't be handled.

Otherwise, nice work as always! r=me

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)

> Personally, I would never have written it this way, I would always put the
> initialization in the for loop expression. So:
> 
> var idx;
> for (idx = 0; ...
> 
> But I'll leave it to you to write it as you see fit. To me it looks strange. :)

idx is used outside of for cycle, therefore I followed this syntax. to be more clear I don't know.

> This must be rephrased to be clear:
> 
> +    // No expected events were registered, proceed to next invoker to ensure
> +    // unexpected events for current invoker won't be handled.

done

> Otherwise, nice work as always! r=me

thank you

Comment 4

[alexander :surkov (:asurkov)]

landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/b976b3535a2f