Closed Bug 591175 Opened 14 years ago Closed 14 years ago

Intermittent failure in test_bug346485.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - checkFormSubmission is not defined

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
x86
Windows Server 2003
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b8

People

(Reporter: philor, Assigned: ehsan.akhgari)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 3 obsolete files)

For check-in
3.82 KB, patch
Details | Diff | Splinter Review 
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1282877649.1282880957.3628.gz
WINNT 5.2 mozilla-central debug test mochitests-1/5 on 2010/08/26 19:54:09
s: win32-slave29

38542 INFO TEST-START | /tests/content/html/content/test/test_bug346485.html
++DOMWINDOW == 16 (16EC4F88) [serial = 851] [outer = 06FA8358]
pldhash: for the table at address 0B86C720, the given entrySize of 48 probably favors chaining over double hashing.
++DOCSHELL 0B86C6B8 == 8
++DOMWINDOW == 17 (0C9F2EA8) [serial = 852] [outer = 00000000]
WARNING: Context has no global.: file e:/builds/moz2_slave/mozilla-central-win32-debug/build/dom/base/nsJSEnvironment.cpp, line 2518
WARNING: Subdocument container has no frame: file e:/builds/moz2_slave/mozilla-central-win32-debug/build/layout/base/nsDocumentViewer.cpp, line 2439
WARNING: Context has no global.: file e:/builds/moz2_slave/mozilla-central-win32-debug/build/dom/base/nsJSEnvironment.cpp, line 2518
++DOMWINDOW == 18 (14E0E788) [serial = 853] [outer = 0C9F2E70]
38543 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_bug346485.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - checkFormSubmission is not defined at http://mochi.test:8888/tests/content/html/content/test/test_bug346485.html:1
JavaScript error: http://mochi.test:8888/tests/content/html/content/test/test_bug346485.html, line 1: checkFormSubmission is not defined
Attached patch Fix (obsolete) — — Splinter Review 
Per bug 556698 comment 248.
Attachment #492040 - Flags: review?(mounir.lamouri)
Assignee: nobody → philringnalda
Comment on attachment 492040 [details] [diff] [review]
Fix

Wouldn't it be better to run the test after the onload event?
It would certainly have been better to have run the test at least once before asking for review, anyway :)
Attachment #492040 - Attachment is obsolete: true
Attachment #492040 - Flags: review?(mounir.lamouri)
Yeah, that's going to require a longer attention span than I possess, to actually understand what the iframe onload is actually there for - I know it has to be after the <script>, but I'd have to actually know what the test had in mind to know what parts really want to happen when.
Assignee: philringnalda → nobody
I'm going to take care of this.
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attached patch Patch (v1) (obsolete) — — Splinter Review 
Sorry Mounir for stealing this from you!
Assignee: mounir.lamouri → ehsan
Attachment #492255 - Flags: review?(mounir.lamouri)
Attached patch Patch (v1) (obsolete) — — Splinter Review 
Forgot a 'hg add'.
Attachment #492255 - Attachment is obsolete: true
Attachment #492256 - Flags: review?(mounir.lamouri)
Attachment #492255 - Flags: review?(mounir.lamouri)
Comment on attachment 492256 [details] [diff] [review]
Patch (v1)

>diff --git a/content/html/content/test/Makefile.in b/content/html/content/test/Makefile.in
>+		bug346485_target.html \

>diff --git a/content/html/content/test/bug346485_target.html b/content/html/content/test/bug346485_target.html
>+test file

I don't think you have to add this file.

>diff --git a/content/html/content/test/test_bug346485.html b/content/html/content/test/test_bug346485.html
>-  <form id='f' method='get' target='submit_frame' action='foo'>
>+  <form id='f' method='get' target='submit_frame' action='bug346485_target.html'>

It wasn't working with action='foo'? You can use action='data:text,html," if you want something "working". (foo was very likely throwing a 404 error)

r=me without the new file.
Attachment #492256 - Flags: review?(mounir.lamouri) → review+
Attached patch For check-in — — Splinter Review 
(In reply to comment #30)
> Comment on attachment 492256 [details] [diff] [review]
> Patch (v1)
> 
> >diff --git a/content/html/content/test/Makefile.in b/content/html/content/test/Makefile.in
> >+		bug346485_target.html \
> 
> >diff --git a/content/html/content/test/bug346485_target.html b/content/html/content/test/bug346485_target.html
> >+test file
> 
> I don't think you have to add this file.

I don't _have to_, but the fact that the test was trying to access a non-existing resource seemed like a mistake to me.

> >diff --git a/content/html/content/test/test_bug346485.html b/content/html/content/test/test_bug346485.html
> >-  <form id='f' method='get' target='submit_frame' action='foo'>
> >+  <form id='f' method='get' target='submit_frame' action='bug346485_target.html'>
> 
> It wasn't working with action='foo'? You can use action='data:text,html," if
> you want something "working". (foo was very likely throwing a 404 error)
> 
> r=me without the new file.

No, it does work with action="foo".  I removed the target file from the patch.
Attachment #492256 - Attachment is obsolete: true
Whiteboard: [orange] → [orange][needs landing]
(In reply to comment #32)
> Created attachment 492642 [details] [diff] [review]
> For check-in
> 
> (In reply to comment #30)
> > Comment on attachment 492256 [details] [diff] [review] [details]
> > Patch (v1)
> > 
> > >diff --git a/content/html/content/test/Makefile.in b/content/html/content/test/Makefile.in
> > >+		bug346485_target.html \
> > 
> > >diff --git a/content/html/content/test/bug346485_target.html b/content/html/content/test/bug346485_target.html
> > >+test file
> > 
> > I don't think you have to add this file.
> 
> I don't _have to_, but the fact that the test was trying to access a
> non-existing resource seemed like a mistake to me.

I usually use "data:text/html," in that case.
http://hg.mozilla.org/mozilla-central/rev/f18b9274235c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [orange][needs landing] → [orange]
Target Milestone: --- → mozilla2.0b8
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: