591212 - The style inspector should react to dynamic changes to the pages stylesheets

Status: REOPENED

(DevTools :: Inspector, defect, P3)

Description

[Joe Walker [:jwalker]]

The current csslogic patch in bug 582596 caches the sheets:

>+      // Hunt down top level stylesheets, and cache them.
>+      let domSheets = this.viewedDocument.styleSheets;

What if a page dynamically adds stylesheets after you've created this static cache?

We are doing performance work in bug 589849. This will change the need for a cache, but if it does not eradicate it, we should ensure that we use a dom mutation event to keep our cache up to date.

Comment 1

[Joe Walker [:jwalker]]

Also from csslogic:

>+        if (domSheet.disabled) {
>+          continue;
>+        }

If a page toggles .disabled or uses .insertRule() / .deleteRule() we should also remain updated.

Comment 2

[Kevin Dangoor]

Reprioritizing bugs. You can filter the mail on the word TEABAGS.

Comment 3

[Mihai Sucan [:msucan]]

Joe: if the performance work I did in bug 589849 is fine with you, then this work should be based on that, if Kevin agrees. Otherwise, the work being done here will need big changes - as explained in the comments of that bug. If you want, we can schedule a meeting to discuss technical aspects.

Comment 4

[Joe Walker [:jwalker]]

I'll prioritize reviewing your changes in bug 589849

Comment 5

[Joe Walker [:jwalker]]

Can I suggest that we treat this a lower priority than getting something merged into central?

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Bug triage, filter on PEGASUS.

Comment 7

[Paul Rouget [:paul]]

This is even more relevant now we have a StyleEditor.

Open the Inspector.
Open the Style Editor.
Make a change a in the Style Editor.
Inspector Rule View not updated.

Comment 8

[Paul Rouget [:paul]]

Bug triage, filter on PINKISBEAUTIFUL

Comment 10

[Tim Nguyen :ntim]

Misunderstood this bug.

Comment 11

[Alexandre Poirot [:ochameau]]

comment 7 is not longer a valid STR. Styles updates in the style editor get updates in the rule view.
But modifying stylesheet via the split console doesn't update the rule view.

Here is a valid STR:
* open: data:text/html,<style>* {background: gray;}</style>foo
* open the webconsole
* execute these commands and see no updates in the rule view:

  document.styleSheets[0].cssRules[0].style.background = "blue";
  document.styleSheets[0].disabled = true;

May be this bug should be in the top inspector bugs?
I don't know how frequent dynamic stylesheet modification is?
It could be if any common framework do so...

Comment 12

[Patrick Brosset <:pbro>]

(In reply to Alexandre Poirot [:ochameau] from comment #11)
> comment 7 is not longer a valid STR. Styles updates in the style editor get
> updates in the rule view.
> But modifying stylesheet via the split console doesn't update the rule view.
> 
> Here is a valid STR:
> * open: data:text/html,<style>* {background: gray;}</style>foo
> * open the webconsole
> * execute these commands and see no updates in the rule view:
> 
>   document.styleSheets[0].cssRules[0].style.background = "blue";
>   document.styleSheets[0].disabled = true;
> 
> May be this bug should be in the top inspector bugs?
> I don't know how frequent dynamic stylesheet modification is?
> It could be if any common framework do so...
The assumption when we implemented the as-authored styles in the rule-view was that this was not very common. So we decided to not handle CSSOM changes then. :tromey had filed bug 1196250 to investigate how to implement that later.