591313 - Search engine list not scrollable

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[ahoza]

BuildID: Mozilla/5.0 (Android; Linux armv7l; rv:2.0b5pre) Gecko/20100827
Namoroka/4.0b5pre Fennec/2.0b1pre
Device: Nokia N900

Steps to reproduce:

1. Start fennec
2. Go to addons.mozilla.org, click on the favicon to the left of the URL bar.
In the identity panel that appears, click on the "Add Search ..." option.
3. Go to bugzilla.mozilla.org, click on the favicon to the left of the URL bar.
In the identity panel that appears, click on the "Add Search ..." option.
4. Tap in URL bar and open search engine list

Expected results:
All enabled search engines are visible in the list; it list is to large than it should scroll

Actual results:
When list is too long it cannot be scrolled.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: fix

We were missing a flex on the scrollable richlistbox.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 469850 [details] [diff] [review]
fix

Arrrgh. Bug 590476 regressed this code. We _did_ have a flex in there.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/6e5189f9d6f0

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED On builds:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100830 Namoroka/4.0b5pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100830 Namoroka/4.0b5pre Fennec/2.0a1pre