591349 - csslogic discovers DOM Rules with no selectorText

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Joe Walker [:jwalker]]

It's not clear that this is reproducible yet, however I'd like to leave a bug so we don't forget.

See csslogic.js around line 456

Comment 1

[Joe Walker [:jwalker]]

It does look reproducible.
See http://getfirebug.com/firstrun#Firebug%201.6.0b1

Comment 2

[Mihai Sucan [:msucan]]

That's interesting. Will test soon.

My initial thought was that domRules without .selectorText can only come from elements that have .style. Still, we have to check the CSS specs and see on that page you linked what happens.

Comment 3

[Mihai Sucan [:msucan]]

Just checked the spec:

http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSSRule

There are CSSRules that have no .selectorText. I think we want to skip those that do not have .selectorText. We should only care about @imports, and possibly @media rules.

Comment 4

[Joe Walker [:jwalker]]

I have added an escape for this already, but we should possibly check the .type rather than .selectorText. Arguments both ways, but possibly we can just leave the code as it is now with the removal of a comment.

Comment 5

[Joe Walker [:jwalker]]

This is fixed (with a comment) in the main patch now.
Mihai's current performance patch removes the comment, which is the correct thing to do.