591430 - Reflect.parse(): TOK_NAME statement nodes with pn_lexdef

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Dave Herman [:dherman]]

js> Reflect.parse("function f() { function g() { } function g() { } }")
Assertion failure: unexpected statement type, at ../jsreflect.cpp:1899
Segmentation fault

Comment 1

[Dave Herman [:dherman]]

Attachment: follow the pn_lexdef link to find the real parse node

Fix attached.

Dave

Comment 2

[Chris Leary [:cdleary] (not checking bugmail)]

Comment on attachment 469960 [details] [diff] [review]
follow the pn_lexdef link to find the real parse node

This fix looks correct, but there are probably some more def/use chain crashers lurking: 'Reflect.parse("function f(g) { function g() { } function g() { } }' asserts out for me.

Comment 3

[Dave Herman [:dherman]]

With the patches applied, WFM. If you see other def/use chain issues, though, please let me know.

Dave

Comment 4

[Dave Herman [:dherman]]

http://hg.mozilla.org/tracemonkey/rev/e13778864fca

Comment 5

[Dave Herman [:dherman]]

> With the patches applied, WFM.

Ah, the test case in comment 2 is a dup of bug 591437. With that bug's fix it works.

Dave

Comment 6

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/e13778864fca