Closed Bug 591431 Opened 11 years ago Closed 11 years ago

Reflect.parse(): JSOP_*XMLNAME nodes as lvalues

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dherman, Assigned: dherman)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

TOK_UNARY cases include JSOP_SETXMLNAME and JSOP_BINDXMLNAME
6.01 KB, patch
cdleary
: review+
Details | Diff | Splinter Review 
js> Reflect.parse("x::y = foo")
Assertion failure: op > UNOP_ERR && op < UNOP_LIMIT, at ../jsreflect.cpp:2160
Segmentation fault
Attachment #469963 - Flags: review?(cdleary)
Comment on attachment 469963 [details] [diff] [review]
TOK_UNARY cases include JSOP_SETXMLNAME and JSOP_BINDXMLNAME

Straightforward and nice test coverage -- that's the best kind of patch!
Attachment #469963 - Flags: review?(cdleary) → review+
http://hg.mozilla.org/tracemonkey/rev/537dd6f60dcc
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/537dd6f60dcc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.