Reflect.parse(): JSOP_*XMLNAME nodes as lvalues

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: dherman, Assigned: dherman)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
js> Reflect.parse("x::y = foo")
Assertion failure: op > UNOP_ERR && op < UNOP_LIMIT, at ../jsreflect.cpp:2160
Segmentation fault
(Assignee)

Comment 1

8 years ago
Created attachment 469963 [details] [diff] [review]
TOK_UNARY cases include JSOP_SETXMLNAME and JSOP_BINDXMLNAME

Fix attached.

Dave
(Assignee)

Updated

8 years ago
Attachment #469963 - Flags: review?(cdleary)
Comment on attachment 469963 [details] [diff] [review]
TOK_UNARY cases include JSOP_SETXMLNAME and JSOP_BINDXMLNAME

Straightforward and nice test coverage -- that's the best kind of patch!
Attachment #469963 - Flags: review?(cdleary) → review+
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/tracemonkey/rev/537dd6f60dcc
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/537dd6f60dcc
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.