591435 - need to honour paint suppression in subdocuments

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Timothy Nikkel (:tnikkel)]

We only look at the paint suppression of the root document we are painting. We never check if a subdocument we are painting is suppressed. Adding bug 130078 into the mix makes this a lot more important to do since the main content window is now a subdocument.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Part 1. Honour paint suppression in subdocuments.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+  if (builder.GetHadToIgnorePaintSuppression()) {
+    willFlushLayers = PR_TRUE;
+  }

This should be unnecessary, if we modify PresShell::UnsuppressAndInvalidate to call rootFrame->InvalidateFrameSubtree() --- which just landed!

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: Part 2. Fix tests that were relying on a lack of paint suppression in subdocuments.

content/base/test/test_bug333198.html and content/events/test/test_bug402089.html use nsIDOMWindowUtils::SendMouseEvent to send some events off onload, in PresShell::HandleEvent when we call nsLayoutUtils::GetFrameForPoint it does not pass true for ignore paint suppression so the events don't find their intended targets.

Comment 4

[Timothy Nikkel (:tnikkel)]

Attachment: Part 1 v2. Honour paint suppression in subdocuments.

Use InvalidateFrameSubtree in UnsuppressAndInvalidate instead of keeping track.

Comment 5

[Timothy Nikkel (:tnikkel)]

Attachment: Part 2 v2. Fix tests that were relying on a lack of paint suppression in subdocuments.

Fix tests better.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+  // *and after* we draw. We don't need flush for PAINT_IGNORE_SUPPRESSION
+  // because we flush in PresShell::UnsuppressAndInvalidate.

Hmm. I think I put you wrong. If someone does a paint with PAINT_IGNORE_SUPPRESSION, and then we do a normal paint, seems like we'll paint the contents of ThebesLayers that show unsuppressed content.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 470704 [details] [diff] [review]
Part 1. Honour paint suppression in subdocuments.

Let's go with this.

Comment 8

[Mats Palmgren (inactive)]

Comment on attachment 470721 [details] [diff] [review]
Part 2 v2. Fix tests that were relying on a lack of paint suppression in subdocuments.

nit: use <!-- --> for those comments

Comment 9

[Timothy Nikkel (:tnikkel)]

(In reply to comment #8)
> nit: use <!-- --> for those comments

Done. Thanks Mats.

Comment 10

[Dão Gottwald [::dao]]

Comment on attachment 470704 [details] [diff] [review]
Part 1. Honour paint suppression in subdocuments.

Land it, please!

Comment 11

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/a7e7578e3ba7
http://hg.mozilla.org/mozilla-central/rev/b38d6617f160