Last Comment Bug 591483 - Port |Bug 465090 - Add keyboard shortcut to open Addons Manager| to SeaMonkey
: Port |Bug 465090 - Add keyboard shortcut to open Addons Manager| to SeaMonkey
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: UI Design (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: seamonkey2.1b2
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
Mentors:
Depends on: 465090 606208
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-27 15:08 PDT by Jens Hatlak (:InvisibleSmiley)
Modified: 2010-10-21 16:14 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (2.82 KB, patch)
2010-08-27 15:08 PDT, Jens Hatlak (:InvisibleSmiley)
no flags Details | Diff | Splinter Review
patch v2 (5.70 KB, patch)
2010-10-09 11:59 PDT, Jens Hatlak (:InvisibleSmiley)
neil: superreview+
Details | Diff | Splinter Review
patch v2a [Checkin: comment 17] (6.39 KB, patch)
2010-10-17 12:23 PDT, Jens Hatlak (:InvisibleSmiley)
mnyromyr: review+
jh: superreview+
Details | Diff | Splinter Review

Description Jens Hatlak (:InvisibleSmiley) 2010-08-27 15:08:24 PDT
Created attachment 470041 [details] [diff] [review]
patch

Firefox is adding a keyboard shortcut (Ctrl+Shift+A) for the Add-on Manager. I think we should follow suit(e).
Comment 1 neil@parkwaycc.co.uk 2010-08-27 15:58:44 PDT
(In reply to comment #0)
> Firefox is adding a keyboard shortcut (Ctrl+Shift+A) for the Add-on Manager. I
> think we should follow suit(e).
That's Select Thread in MailNews :-(
Comment 2 Jens Hatlak (:InvisibleSmiley) 2010-08-29 09:25:09 PDT
(In reply to comment #1)
> That's Select Thread in MailNews :-(

That's really unfortunate. Same with TB. Maybe we should see what they'll do?

I wonder whether we can remove that shortcut over there--or will people kill us (esp. me) for that? I didn't know this existed at all! Edit/Select/Flagged Messages hat no shortcut either BTW.

Or maybe add the new shortcut only to browser windows? I mean, now that it's a tab...
Comment 3 Robert Kaiser 2010-08-29 11:25:29 PDT
Good luck with finding a free shortcut in mailnews. I'm not aware of any, I know we already had large problems finding one for download manager.
Comment 4 Jens Hatlak (:InvisibleSmiley) 2010-08-29 11:50:10 PDT
(In reply to comment #3)
> Good luck with finding a free shortcut in mailnews. I'm not aware of any, I
> know we already had large problems finding one for download manager.

If you had read my comment 2 you would have seen that I have no intention to find a shortcut that is currently free in MailNews. I'm well aware of the situation.
Comment 5 Bruno 'Aqualon' Escherl 2010-08-29 12:15:36 PDT
ehm, select Thread is Alt+Shift+A not Ctrl+Shift+A
Comment 6 Jens Hatlak (:InvisibleSmiley) 2010-08-29 12:20:13 PDT
(In reply to comment #5)
> ehm, select Thread is Alt+Shift+A not Ctrl+Shift+A

Only on Linux/Unix (see below). But thanks for noticing, this might be our way out (using that shortcut on all platforms)! :-) Neil, KaiRo, what do you think?

<http://mxr.mozilla.org/comm-central/search?string=key_selectThread>
Comment 7 Robert Kaiser 2010-08-29 15:08:04 PDT
(In reply to comment #2)
> Or maybe add the new shortcut only to browser windows? I mean, now that it's a
> tab...

No, even if it opens in a tab, it's a cross-component feature. And that's it's currently a browser tab is a technical detail that will not survive indefinitely anyhow.

(In reply to comment #6)
> Neil, KaiRo, what do you think?

I think that this all is a really bug mess and we have too many options with shortcuts, and MailNews is too complicated. But that leads too far.

I'll let Neil decide, he knows more than any of us about shortcuts.
Comment 8 neil@parkwaycc.co.uk 2010-08-29 16:08:21 PDT
The only idea I could come up with was to move select thread to Shift+A.

But it's Mnyromyr's module, so he gets final say ;-)
Comment 9 Jens Hatlak (:InvisibleSmiley) 2010-09-02 10:54:32 PDT
(In reply to comment #8)
> The only idea I could come up with was to move select thread to Shift+A.

That's Archive. ;-)

> But it's Mnyromyr's module, so he gets final say ;-)

So, here some thoughts why I think making Select Thread Alt+Shift+A on all platforms and making Ctrl+A open the Add-on Manager is the way to go:
1. Ctrl+Key shortcuts are first-class. People who use add-ons open the Add-on Manager quite frequently, from whichever module they're currently in (say, browser or MailNews).
2. Alt+Shift shortcuts are not first-class. As is Select Thread (contrary to Select).
3. Alt+Shift shortcuts are semi-reserved for website shortcuts (accesskey HTML attribute) which are more likely to appear in content opened in the browser (any website) than MailNews (feeds only)
4. Alt+Shift+A is already used on Unix/Linux, so achieving consistency there would also mean less confusion. 
5. Firefox uses Ctrl+A for the Add-on Manager, so this would be consistent (I put this point last on purpose).

Please ignore the current patch for now and consider the above only.
Comment 10 neil@parkwaycc.co.uk 2010-09-04 08:39:55 PDT
(In reply to comment #9)
> (In reply to comment #8)
> > The only idea I could come up with was to move select thread to Shift+A.
> That's Archive. ;-)
Sigh. I guess "A" was deemed too dangerous.

> So, here some thoughts why I think making Select Thread Alt+Shift+A on all
> platforms and making Ctrl+A open the Add-on Manager is the way to go:
You mean Ctrl+Shift+A, right?
Comment 11 Jens Hatlak (:InvisibleSmiley) 2010-09-04 14:12:42 PDT
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > So, here some thoughts why I think making Select Thread Alt+Shift+A on all
> > platforms and making Ctrl+A open the Add-on Manager is the way to go:
> You mean Ctrl+Shift+A, right?

Good catch. I have absolutely no intention to re-purpose Ctrl+A. ;-)
Comment 12 Karsten Düsterloh 2010-09-05 13:03:24 PDT
(In reply to comment #11)
> > You mean Ctrl+Shift+A, right?
> Good catch. I have absolutely no intention to re-purpose Ctrl+A. ;-)

Phewy, you really made me worry. ;-)
Comment 13 Jens Hatlak (:InvisibleSmiley) 2010-10-09 11:59:43 PDT
Created attachment 482064 [details] [diff] [review]
patch v2
Comment 14 neil@parkwaycc.co.uk 2010-10-10 12:52:23 PDT
Comment on attachment 482064 [details] [diff] [review]
patch v2

OK, I can live with this.
Comment 15 Karsten Düsterloh 2010-10-17 11:49:55 PDT
Comment on attachment 482064 [details] [diff] [review]
patch v2

>diff --git a/suite/locales/en-US/chrome/common/tasksOverlay.dtd b/suite/locales/en-US/chrome/common/tasksOverlay.dtd
> <!ENTITY downloadManagerCmd.label "Download Manager">
> <!ENTITY downloadManagerCmd.accesskey "D">
> <!ENTITY downloadManagerCmd.commandkey "j">
> 
> <!ENTITY addonsManagerCmd.label "Add-on Manager">
> <!ENTITY addonsManagerCmd.accesskey "A">
>+<!ENTITY addonsManagerCmd.commandkey "A">

This should be a lower case "a".

r=me with that.
Comment 16 Jens Hatlak (:InvisibleSmiley) 2010-10-17 12:23:33 PDT
Created attachment 483854 [details] [diff] [review]
patch v2a [Checkin: comment 17]

Nit addressed, re-requesting review for the added AOM shortcut documentation.
Comment 17 Jens Hatlak (:InvisibleSmiley) 2010-10-18 09:46:46 PDT
Comment on attachment 483854 [details] [diff] [review]
patch v2a [Checkin: comment 17]

http://hg.mozilla.org/comm-central/rev/92544eb8a854

Note You need to log in before you can comment on or make changes to this bug.